Skip to content

chore(deps): update @agicash/breez-sdk-spark to 0.23.0-1 (live) - #1182

Merged
jbojcic1 merged 1 commit into
livefrom
deps/breez-sdk-spark-0.23.0-1-live
Aug 27, 2026
Merged

chore(deps): update @agicash/breez-sdk-spark to 0.23.0-1 (live)#1182
jbojcic1 merged 1 commit into
livefrom
deps/breez-sdk-spark-0.23.0-1-live

Conversation

@ditto-agent

Copy link
Copy Markdown
Contributor

Summary

Applies #1181 to the live branch. Live predates the wallet-sdk extraction, so a cherry-pick did not apply; the same changes are re-applied to the old file layout (app/lib/spark/utils.ts, app/features/shared/spark.ts, app/features/send|receive/...).

  • Bumps @agicash/breez-sdk-spark from 0.13.5-1 to 0.23.0-1 in apps/web-wallet (no catalog move here: on live only one package uses the dep).
  • defaultExternalSignerdefaultExternalSigners; getSparkIdentityPublicKeyFromMnemonic is now async. Its only caller on live is the async queryFn in sparkIdentityPublicKeyQueryOptions, so the change does not ripple.
  • Config.optimizationConfigConfig.leafOptimizationConfig.
  • prepareSendPayment takes a tagged-union paymentRequest: { type: 'input', input } (2 call sites).
  • getLightningQuote param renamed to receiverIdentityPublicKey to match the SDK field (same as the master rename commit).

Verification

  • bun run fix:all: clean
  • bun run typecheck: 3/3 workspaces green
  • bun run test: 133 pass / 0 fail
  • Plain bun install passes from the lockfile, so the 3-day minimumReleaseAge gate does not block CI.

🤖 Generated with Claude Code

Same change as #1181 (master commits 003d3ae + 64d6878), applied to
the pre-SDK-extraction layout on live:

- defaultExternalSigner -> defaultExternalSigners; identity key now
  comes from the async sparkSigner.getIdentityPublicKey(), so
  getSparkIdentityPublicKeyFromMnemonic is now async
- Config.optimizationConfig -> Config.leafOptimizationConfig
- prepareSendPayment paymentRequest is now a tagged union; wrap the
  bolt11 string as { type: 'input', input }
- rename getLightningQuote param to receiverIdentityPublicKey to match
  the SDK field

The dep stays declared in apps/web-wallet only: on live no second
package uses it, so the catalog move from master does not apply.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agicash Ready Ready Preview Aug 27, 2026 12:44pm

Request Review

@supabase

supabase Bot commented Aug 27, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project hrebgkfhjpkbxpztqqke because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@ditto-agent

Copy link
Copy Markdown
Contributor Author

Note for the next master → live merge: this PR will cause a few extra conflicts. All of them resolve toward master, because master already contains the same change inside packages/wallet-sdk (#1181).

  • Modify/delete conflicts on 5 files this PR touched (master deleted them in the SDK extraction): app/lib/spark/utils.ts, app/features/shared/spark.ts, app/features/send/spark-send-quote-service.ts, app/features/receive/spark-receive-quote-core.ts, app/features/receive/lightning-address-service.ts → accept the deletion (git rm).
  • apps/web-wallet/package.json (live: 0.23.0-1, master: catalog:) → take master.
  • bun.lock → take master, then run bun install.

@jbojcic1
jbojcic1 merged commit e0c7081 into live Aug 27, 2026
6 checks passed
@jbojcic1
jbojcic1 deleted the deps/breez-sdk-spark-0.23.0-1-live branch August 27, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants