ci: pin runners and action SHAs#8
Merged
Merged
Conversation
Pin every job's runner to ubuntu-24.04 (not -latest) and every third-party action to a commit SHA with a version comment, matching the CodeQL workflow and the main SpaceUX repo. A moved tag or a silent runner-image migration can no longer change what runs. Refs Maik-0000FF/SpaceUX#426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hygiene follow-up to the CodeQL PR (Maik-0000FF/SpaceUX#426): make the CI workflow's runners and third-party actions deterministic, matching the CodeQL workflow and the main SpaceUX repo.
ubuntu-24.04instead ofubuntu-latest, so a silent runner-image migration can't break the jobs.actions/checkout-> v6.0.3actions/setup-node-> v6.4.0actions/upload-artifact-> v7.0.1Why
A moving tag (
@v5) is mutable: the action owner (or an attacker who compromises the repo) can repoint it, changing what executes in CI. SHA pinning closes that supply-chain gap. Same convention the main repo already uses.Refs Maik-0000FF/SpaceUX#426