feat: 支持从酒馆选择预设#200
Conversation
🔍 PR Test Report🧪 Test Results✅ All tests passed!
📊 Coverage Report
Coverage Thresholds
Generated at 2026-04-25T10:26:19.765Z |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e929b4cdec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex reivew |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e929b4cdec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex reivew |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4de0fd269e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| if (store.settings.额外模型解析配置.破限方案 === '使用其他预设') { | ||
| const preset = getExtraModelPreset(store.settings.额外模型解析配置.其他预设名称); |
There was a problem hiding this comment.
这里在“使用其他预设”模式下直接调用 getExtraModelPreset，当 其他预设名称 为空或对应预设已被删除时会抛异常，导致额外模型解析在重试策略下反复失败而不会回退；这个场景在无可用预设时很容易出现（面板会把该字段置空）。建议在调用前做存在性校验并给出可见提示或降级策略。
Useful? React with 👍 / 👎.
| import HelpIcon from '../component/HelpIcon.vue'; | ||
|
|
||
| const store = useDataStore(); | ||
| const available_preset_names = computed(() => getAvailableExtraModelPresetNames()); |
There was a problem hiding this comment.
available_preset_names 由一个没有响应式依赖的 computed 生成，实际会在挂载后变成快照值；后续用户新增/删除 preset 时，watch(available_preset_names, ...) 不会再触发，其他预设名称 可能保持失效值并在请求时触发读取预设失败。建议改为由可触发更新的事件/状态驱动，或在请求前实时重新拉取并校验可用预设名。
Useful? React with 👍 / 👎.
1 participant
如题，不过只是排布提示词按照预设里的，实际对于部分参数可能不吻合。