Repository navigation
Listen to icon pickers directly and order buttons like a fader for 0.2.0b2 - #12
Merged
Merged
Conversation
…2.0b2 Home Assistant's icon picker fires value-changed without bubbling, so the listeners on the shadow root never heard a choice. The card editor and the setup page now listen on each picker. Beside the control, buttons are shown in reverse order with the power button at the bottom, matching a fader that is brightest at the top. The glow and its setting are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icon pickers, button order beside the control and the glow, for 0.2.0b2.
Fixed
Changed
The frontend harness now fires the picker's event the way Home Assistant does (bubbles: false, composed: false) and checks the button order in both layouts.