Repository navigation
Restructure into api/core/paper/bungee/velocity, ship jars in builds/, support Folia - #4
Merged
Merged
Conversation
…, support Folia
- Rename the common module to core (package com.friends.core).
- builds/: every build syncs friends-paper/-velocity/-bungee/-api.jar there; the
unused thin plugin jars are no longer built.
- verifyBuilds (part of check): descriptor versions, Folia flag, each platform's
own events only, relocated libraries, Java 8 bytecode for the Paper and API
jars, no file-sync copies ("Foo 2.class") inside the jars.
- Folia: the Paper jar declares folia-supported; the request-expiry timer moves
from each platform's scheduler into FriendsRuntime (Folia has no Bukkit
scheduler), and a failing run no longer cancels later ones.
- Velocity's @plugin version is generated from the build version.
- API usage guide in api/README.md; README, e2e runner (folia-<version>
scenario, jars from builds/) and CI (build + verify, upload builds/*.jar) updated.
- .gitignore: builds/, IDE and Claude Code files, test sources; untrack
.vscode/, .claude/ and src/test (kept locally).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commonis nowcore(packagecom.friends.core). The modules areapi/,core/,paper/,bungee/andvelocity/, and any future platform gets its own top-level folder.builds/: every build syncsfriends-paper.jar,friends-velocity.jar,friends-bungee.jarandfriends-api.jarthere. The folder is gitignored, and the unused thin plugin jars are no longer built.verifyBuilds(part ofcheck) asserts:Foo 2.class) are inside.folia-supported: true. The request-expiry timer moved from the three platform schedulers intoFriendsRuntime, and a failing run no longer cancels later ones.@Plugin(version)is generated from the build version.api/README.mdis the API usage guide, and the README is updated.builds/and has afolia-<version>scenario.builds/*.jar.**/src/test/),.vscode/and.claude/.Test plan
./gradlew build --rerun-taskswith the MySQL 8.0.46 and Redis 8.10.2 suites: 164 test runs, 0 failures. The two skips are by design.RuntimeTest: the core timer expires requests and keeps going after a failing run. It fails without the fix.verifyBuildsfails as expected when injected faults are added (a file-sync copy, another platform's events in a jar).NO-SOURCE,verifyBuildsgreen.🤖 Generated with Claude Code