cleanup: remove nested duplicate folder, salvage two ideas to ROADMAP#3
Merged
Conversation
Both ideas surfaced from inspecting PR #2's parallel implementation before dropping it. Worth flagging as future work; the code itself isn't portable (different model names, float vs Decimal money, different routes pattern).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the stale
ecom-dynamic-pricing/folder at root and salvages two design ideas into ROADMAP before dropping the rest.What was in the nested folder
PR #2 (a parallel Claude Code session,
claude/saas-backend-skeleton-fastapi-postgres-celery-...) merged into main before PR #1 and dropped a complete competing implementation insideecom-dynamic-pricing/. Not a stale copy of the root tree — a parallel fork with different model names (Store/PricingEventvsMerchant/PriceEvent), different routes pattern (routes/vsapi/),floatmoney instead ofDecimal, and an unfinished Tailwind frontend that importedlib/apiandlib/typesfiles which were never written.Salvage decision
Reviewed each candidate before deleting. Final call: drop the code, lift two ideas into ROADMAP.
lib/apiandlib/typesmodules that don't exist; would not build. Cost: 8 new deps + write the missing modules + retrofit my backend to match its expected endpoints.routes/packagepricing_engine.pyfloat, batch interface, concrete signals. Architecturally divergent from theDecimal-based, single-product, abstract-signal engine onmain.HANDOFF.md(566 lines)MERCHANT_QUICKSTART.md(212 lines)OPERATOR_RUNBOOK.md(507 lines)README.md(963 lines),TECHNICAL_DEBT.md(744 lines),ROADMAP.md(119 lines)Last Updated: 2025-01-13footers (forbidden operator-language residue).max_increase_pctvsmax_decrease_pct)Final root tree
Sanity scan
claude|anthropic|cowork|lovable|last updated|voice match|audit-defensible|operator note|justin|krishnamurthy|gpt|gemini).access_tokencolumn,self.access_token = access_token); no secret values.Diff size
46 files changed: 2 insertions (ROADMAP additions), 6021 deletions (nested folder).
Test plan
git log --oneline main..HEADshows one commitlsat root shows the file list above with noecom-dynamic-pricing/directoryGenerated by Claude Code