Skip to content

cleanup: remove nested duplicate folder, salvage two ideas to ROADMAP#3

Merged
MacFall7 merged 1 commit into
mainfrom
claude/remove-nested-duplicate
May 13, 2026
Merged

cleanup: remove nested duplicate folder, salvage two ideas to ROADMAP#3
MacFall7 merged 1 commit into
mainfrom
claude/remove-nested-duplicate

Conversation

@MacFall7
Copy link
Copy Markdown
Owner

Summary

Removes the stale ecom-dynamic-pricing/ folder at root and salvages two design ideas into ROADMAP before dropping the rest.

What was in the nested folder

PR #2 (a parallel Claude Code session, claude/saas-backend-skeleton-fastapi-postgres-celery-...) merged into main before PR #1 and dropped a complete competing implementation inside ecom-dynamic-pricing/. Not a stale copy of the root tree — a parallel fork with different model names (Store/PricingEvent vs Merchant/PriceEvent), different routes pattern (routes/ vs api/), float money instead of Decimal, and an unfinished Tailwind frontend that imported lib/api and lib/types files which were never written.

Salvage decision

Reviewed each candidate before deleting. Final call: drop the code, lift two ideas into ROADMAP.

Candidate Decision Reason
Frontend Tailwind components Drop Imports lib/api and lib/types modules that don't exist; would not build. Cost: 8 new deps + write the missing modules + retrofit my backend to match its expected endpoints.
Backend routes/ package Drop Architectural fork — different models, different schemas, different API surface. Not portable.
pricing_engine.py Drop Uses float, batch interface, concrete signals. Architecturally divergent from the Decimal-based, single-product, abstract-signal engine on main.
HANDOFF.md (566 lines) Drop Session-handoff framing that doesn't fit a portfolio artifact.
MERCHANT_QUICKSTART.md (212 lines) Drop Assumes a live deployment.
OPERATOR_RUNBOOK.md (507 lines) Drop Same as above.
README.md (963 lines), TECHNICAL_DEBT.md (744 lines), ROADMAP.md (119 lines) Drop Existing root versions are intentionally tight; merging would inflate without adding signal. All three carried Last Updated: 2025-01-13 footers (forbidden operator-language residue).
Suspend/resume automation primitive Salvage to ROADMAP Genuinely interesting safety primitive. Complements rollback — rollback fixes the past, suspend prevents the next move. Added under "Soon".
Asymmetric guardrail caps (max_increase_pct vs max_decrease_pct) Salvage to ROADMAP Real merchant preference (prices fall slower than they rise). Added under "Later".

Final root tree

.github/workflows/
backend/
frontend/
.env.example
.gitignore
LICENSE
README.md
ROADMAP.md
TECHNICAL_DEBT.md
docker-compose.yml

Sanity scan

  • Forbidden-language scan on the cleaned tree: clean (zero matches for claude|anthropic|cowork|lovable|last updated|voice match|audit-defensible|operator note|justin|krishnamurthy|gpt|gemini).
  • Secret-shaped scan on the cleaned tree: only legitimate field/attribute names (access_token column, self.access_token = access_token); no secret values.

Diff size

46 files changed: 2 insertions (ROADMAP additions), 6021 deletions (nested folder).

Test plan

  • CI passes on this branch (ruff + pytest + vite build — unchanged from main since no functional code touched)
  • git log --oneline main..HEAD shows one commit
  • ls at root shows the file list above with no ecom-dynamic-pricing/ directory

Generated by Claude Code

Both ideas surfaced from inspecting PR #2's parallel implementation
before dropping it. Worth flagging as future work; the code itself
isn't portable (different model names, float vs Decimal money,
different routes pattern).
@MacFall7 MacFall7 merged commit d7ab0e4 into main May 13, 2026
2 checks passed
@MacFall7 MacFall7 deleted the claude/remove-nested-duplicate branch May 13, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants