Add minimize button to progress/prompt dialog windows - #39
Open
mnorris14 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds swiftDialog's
--windowbuttons minflag to Patchomator's two swiftDialog invocations:dialogTimeoutPrompt()(used for the "Replace label...?" and "Install Installomator?" prompts)Also bumps
VERSIONfrom1.2to1.2-om1to distinguish this build.Why
swiftDialog's
--windowbuttonsoption controls which of the standard macOS title-bar window controls (close/minimize/zoom) are drawn on the dialog. Passingminadds just the yellow minimize button.Today both dialogs are shown with
--ontopand--moveablebut no window controls at all, so there is no way for a user (or admin watching over someone's shoulder) to get the dialog out of the way during a run — it can be dragged around, but not minimized or hidden, and it will stay on top of everything else on screen for the whole run. For --install runs in particular, this can be a long-running, unattended-feeling window with no way to tuck it out of sight. Adding the minimize button gives users an unobtrusive way to temporarily dismiss the window without closing/canceling the underlying process.What's intentionally unchanged
--ontopand--moveableare left exactly as they were on both invocations. This change only adds the ability to minimize; it does not change stacking behavior or make the dialogs any less "always on top" than before, and it does not add a close button.Testing
Patched and rebuilt locally; the two
--windowbuttons minadditions and the version bump have been verified byte-for-byte against the pushed branch content.