Repository navigation
Zero-fill clusters allocated for the FAT32 root directory - #69
Closed
william-spinelli wants to merge 1 commit into
Closed
william-spinelli wants to merge 1 commit into
william-spinelli wants to merge 1 commit into
Conversation
File::is_dir returned false for streams without a directory entry, but the only such stream is the FAT32 root directory. When the root directory grew past its last cluster, the newly allocated cluster was therefore not zero-filled: it kept stale data from previously deleted files, which has no end-of-directory marker and gets parsed as directory entries. Creating enough files (e.g. hundreds of entries with long file names) reliably produced bogus files and directories with garbled names and dates, even after a clean unmount. Treat entry-less streams as directories so alloc_cluster zeroes the new cluster.
Contributor
|
this got fixed in #70, along with some tests of the underlying issue, so can be closed. |
Author
|
Well thanks anyway :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File::is_dir returned false for streams without a directory entry, but the only such stream is the FAT32 root directory. When the root directory grew past its last cluster, the newly allocated cluster was therefore not zero-filled: it kept stale data from previously deleted files, which has no end-of-directory marker and gets parsed as directory entries.
Creating enough files (e.g. hundreds of entries with long file names) reliably produced bogus files and directories with garbled names and dates, even after a clean unmount.
Treat entry-less streams as directories so alloc_cluster zeroes the new cluster.