Repository navigation
fix: accept both BPB sector count fields, valid NullTimeProvider date - #64
Merged
Merged
Conversation
MabezDev
force-pushed
the
fix/spec-compliance
branch
2 times, most recently
from
May 1, 2026 17:12
0839278 to
b3b0e5d
Compare
bugadani
reviewed
May 2, 2026
| if self.is_fat32() { | ||
| FsStatusFlags::decode(self.reserved_1) | ||
| } else { | ||
| // FAT12/FAT16 BPB does not carry status flags; they live in the FAT table |
Collaborator
There was a problem hiding this comment.
Claude says FAT12 has no dirty flag at all, anywhere, so this comment is slightly off
bugadani
reviewed
May 2, 2026
| } | ||
|
|
||
| pub(crate) async fn set_dirty_flag(&self, dirty: bool) -> Result<(), IO::Error> { | ||
| // FAT12/FAT16 BPB does not carry status flags; skip BPB write for non-FAT32 |
Collaborator
There was a problem hiding this comment.
Claude says: with this change, FAT16 has no dirty-flag persistence at all anymore. The spec-defined FAT16 mechanism (high bits of FAT entry 1) is not implemented as a replacement
…er date Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bugadani
force-pushed
the
fix/spec-compliance
branch
from
October 23, 2026 18:33
b3b0e5d to
e5e40fa
Compare
bugadani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
total_sectors_16andtotal_sectors_32. Reject only both zero.NullTimeProviderreturns 1980-01-01, not month 0 and day 0.