Repository navigation
fix: correct seek overflow and sign bugs in BufStream and StreamSlice - #62
Merged
Merged
Conversation
MabezDev
force-pushed
the
fix/seek-bugs-rebased
branch
7 times, most recently
from
May 1, 2026 17:32
be13d63 to
7106d56
Compare
bugadani
reviewed
May 2, 2026
| .ok() | ||
| .and_then(|o| o.checked_add(x)) | ||
| .map(|o| o.max(0) as u64) | ||
| .unwrap_or(0) |
Collaborator
There was a problem hiding this comment.
I'm not sure if silently not seeking is the right behaviour on overflow, maybe we should instead return an error.
bugadani
reviewed
May 2, 2026
| SeekFrom::Current(x) => (self.current_offset as i64 + x) as u64, | ||
| SeekFrom::End(x) => { | ||
| let size = self.inner.size().await? as i64; | ||
| (size + x).max(0) as u64 |
Collaborator
There was a problem hiding this comment.
Is saturating at 0 actually a meaningful thing to do? Could we return an error instead?
…etic Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bugadani
force-pushed
the
fix/seek-bugs-rebased
branch
from
October 23, 2026 18:33
7106d56 to
974a17d
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeekFrom::Endsign inBufStream.i128inBufStreamandStreamSlice. ReturnInvalidSeekfor a target before 0 or past the limit.block-device-adapterstests in CI.