Repository navigation
Conversation
Contributor
Author
|
@MabezDev I understand that this probably isnt the most ideal API, but I think for high-speed scenarios it could be handy to short-circuit unnecessary overhead. Maybe these functions could be hidden behind a feature flag, for the best of both worlds? |
Owner
|
Once upon a time, this was public - but I'm not happy with how easy it is to misuse it. I'm open on ideas on how to improve it without affecting performance. |
Owner
|
What do you think about #59? Could you test in your app for performance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the visibility of the
new_from_contextfunction to allow it to be called outside of the crate.