feat: add in-repo maa-cli agent skill - #578
Open
LucasIcarus wants to merge 4 commits into
Open
LucasIcarus wants to merge 4 commits into
LucasIcarus wants to merge 4 commits into
Conversation
Give agents a usage guide for running maa-cli instead of scraping --help, including command routing and Depot/OperBox OCR limits.
Give a bare agent enough runtime context to install, connect, and run maa-cli, and point AGENTS.md at the skill for end-user usage versus crate work.
LucasIcarus
force-pushed
the
feat/agent-skill
branch
from
August 20, 2026 04:27
52200ff to
1ecd645
Compare
OCR acquisition and on-demand query are the product; shop advice is only one consumer of those facts.
LucasIcarus
marked this pull request as ready for review
August 20, 2026 05:48
There was a problem hiding this comment.
Hey - 我在这里给出一些整体上的反馈:
- 在
skills/maa-cli/setup.md和SKILL.md中,你通过硬编码的 GitHub URL 链接到install.md/config.md;建议改成仓库相对路径,这样在不同分支和 fork 间也能保持正确。 - 连接预设(connection preset)的表格和说明在
setup.md和SKILL.md之间是重复的;你可能希望将它们整合为单一来源(或者在其中一个文件中显式引用另一个),以减少随时间推移出现指引不一致的风险。
给 AI Agent 的提示词
Please address the comments from this code review:
## Overall Comments
- In `skills/maa-cli/setup.md` and `SKILL.md` you link to `install.md`/`config.md` via hard-coded GitHub URLs; consider switching these to repo-relative paths so they stay correct across branches and forks.
- The connection preset tables/descriptions are duplicated between `setup.md` and `SKILL.md`; you might want to consolidate this into a single source (or explicitly reference one from the other) to reduce the chance of the guidance drifting over time.帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据这些反馈改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- In
skills/maa-cli/setup.mdandSKILL.mdyou link toinstall.md/config.mdvia hard-coded GitHub URLs; consider switching these to repo-relative paths so they stay correct across branches and forks. - The connection preset tables/descriptions are duplicated between
setup.mdandSKILL.md; you might want to consolidate this into a single source (or explicitly reference one from the other) to reduce the chance of the guidance drifting over time.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `skills/maa-cli/setup.md` and `SKILL.md` you link to `install.md`/`config.md` via hard-coded GitHub URLs; consider switching these to repo-relative paths so they stay correct across branches and forks.
- The connection preset tables/descriptions are duplicated between `setup.md` and `SKILL.md`; you might want to consolidate this into a single source (or explicitly reference one from the other) to reduce the chance of the guidance drifting over time.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Keep preset routing in SKILL.md and profile templates in setup.md so the two files stop drifting.
Author
|
Thanks for the review — both points are in
This branch is already based on current |
Member
|
这个是典型的 GPT 写的文档,基本上是把对话的内容搬了进去,真正的 skill 不是这么写的。 |
Author
|
@wangl-cc 你指的是 skill 的正文还是 design doc? |
Member
|
文档的 AI 味很重, skill 本身稍微好一点。我觉得确实可以写一个 skill,但是现在这个版本可能还是要进一步的完善修改一下。你可以开一个新的 session 或者开一个新的 sub agent,让他们注意一下语气,以及要写的目标。 |
Author
design spec 确实是 agent 直出的, 我大概 prompt 了下终态目标.. 我先优化下 skill 本身, 然后把 design spec untrack 下吧.. 不过 skill 目前也只是个壳子 我考虑本地 dogfooding 加些功能先 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an in-repo agent skill so a coding agent can install, connect, and run maa-cli without relying on chat history. The skill is the end-user CLI runbook;
AGENTS.mdstays the crate-contribution guide.Changes
skills/maa-cli/withSKILL.md(cold-start and command routing),setup.md(install and per-platform runtime), andreference.md(task types and recognition limits)AGENTS.mdwhen to update the skill versus when to read it instead of this fileValidation
markdownlint-cli2 --config .markdownlint.yamlon the skill files,README.md,AGENTS.md, andcrates/maa-cli/docs/zh-CN/intro.mdgit diff --checkSummary by Sourcery
提供一个自包含的代理运行手册,用于安装、连接和运行 maa-cli,而不依赖对话上下文。
新特性:
增强:
文档:
Original summary in English
Summary by Sourcery
Provide a self-contained agent runbook for installing, connecting, and operating maa-cli without relying on conversation context.
New Features:
Enhancements:
Documentation:
Original summary in English
Summary by Sourcery
提供一个自包含的代理运行手册,用于安装、连接和运行 maa-cli,而不依赖对话上下文。
新特性:
增强:
文档:
Original summary in English
Summary by Sourcery
Provide a self-contained agent runbook for installing, connecting, and operating maa-cli without relying on conversation context.
New Features:
Enhancements:
Documentation:
Original summary in English
Summary by Sourcery
提供一个自包含的代理运行手册,用于安装、连接和运行 maa-cli,而不依赖对话上下文。
新特性:
增强:
文档:
Original summary in English
Summary by Sourcery
Provide a self-contained agent runbook for installing, connecting, and operating maa-cli without relying on conversation context.
New Features:
Enhancements:
Documentation:
Original summary in English
Summary by Sourcery
提供一个自包含的代理运行手册,用于安装、连接和运行 maa-cli,而不依赖对话上下文。
新特性:
增强:
文档:
Original summary in English
Summary by Sourcery
Provide a self-contained agent runbook for installing, connecting, and operating maa-cli without relying on conversation context.
New Features:
Enhancements:
Documentation:
Original summary in English
Summary by Sourcery
提供一个自包含的代理运行手册,用于安装、连接和运行 maa-cli,而不依赖对话上下文。
新特性:
增强:
文档:
Original summary in English
Summary by Sourcery
Provide a self-contained agent runbook for installing, connecting, and operating maa-cli without relying on conversation context.
New Features:
Enhancements:
Documentation:
Original summary in English
Summary by Sourcery
提供一个自包含的代理运行手册,用于安装、连接和运行 maa-cli,而不依赖对话上下文。
新特性:
增强:
文档:
Original summary in English
Summary by Sourcery
Provide a self-contained agent runbook for installing, connecting, and operating maa-cli without relying on conversation context.
New Features:
Enhancements:
Documentation:
Original summary in English
Summary by Sourcery
提供一个自包含的代理运行手册,用于安装、连接和运行 maa-cli,而不依赖对话上下文。
新特性:
增强:
文档:
Original summary in English
Summary by Sourcery
Provide a self-contained agent runbook for installing, connecting, and operating maa-cli without relying on conversation context.
New Features:
Enhancements:
Documentation:
Original summary in English
Summary by Sourcery
提供一个自包含的代理运行手册,用于安装、连接和运行 maa-cli,而不依赖对话上下文。
新特性:
增强:
文档:
Original summary in English
Summary by Sourcery
Provide a self-contained agent runbook for installing, connecting, and operating maa-cli without relying on conversation context.
New Features:
Enhancements:
Documentation: