Keep API available when MQTT fails#392
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the cloud API usable when MQTT cannot connect, expose MQTT connection state, and reduce aggressive MQTT reconnect behavior that could contribute to broker rate limits.
Changes
This keeps authentication and API refresh working even when the initial MQTT connection fails, then retries MQTT quietly in the background. MQTT reconnect timing is slowed down, paho reconnect backoff is increased, and token refresh no longer forces immediate MQTT reconnects while disconnected.
The MQTT connection state is exposed on both the cloud object and devices, MQTT commands now fail with a clear connection error when MQTT is unavailable, and paho reconnect callbacks resubscribe existing topics so recovered connections remain usable. Legacy unused MQTT resume code and unused private state were removed.
Testing
Notes
Proposed semver label: patch. This label has not been set yet and should be explicitly approved before merge.