Skip to content

[DOP-29428] Add support for Iceberg with REST catalog and S3 warehouse - #284

Merged
IlyasDevelopment merged 1 commit into
developfrom
feature/DOP-29428
Oct 27, 2025
Merged

[DOP-29428] Add support for Iceberg with REST catalog and S3 warehouse#284
IlyasDevelopment merged 1 commit into
developfrom
feature/DOP-29428

Conversation

@IlyasDevelopment

@IlyasDevelopment IlyasDevelopment commented Oct 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Change Summary

Added IcebergRESTCatalogS3Handler to support corresponding transfers.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Oct 24, 2025
@dolfinus

dolfinus commented Oct 27, 2025

Copy link
Copy Markdown
Member

Let's merge changes from develop branch, to fix failing integration tests

@dolfinus
dolfinus self-requested a review October 27, 2025 08:57
@github-actions

github-actions Bot commented Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
syncmaster/dto
   transfers.py97396%74, 117–118
syncmaster/worker
   controller.py92198%244
syncmaster/worker/handlers/db
   iceberg.py442250%31, 56, 60, 63–65, 68–72, 74–76, 78–81, 83, 85, 88, 91
TOTAL503330393% 

dolfinus
dolfinus reviewed Oct 27, 2025
View reviewed changes
Comment thread syncmaster/dto/transfers.py Outdated
dolfinus
dolfinus reviewed Oct 27, 2025
View reviewed changes
Comment thread syncmaster/dto/transfers.py Outdated
@IlyasDevelopment
IlyasDevelopment merged commit 916160c into develop Oct 27, 2025
23 of 24 checks passed
@IlyasDevelopment
IlyasDevelopment deleted the feature/DOP-29428 branch October 27, 2025 14:52

This branch had an error being deployed

1 failed deployment
test-pypi — 8d9a7bb4 Deployed Oct 27, 2025 by IlyasDevelopment via Dev release package #1341
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolfinus dolfinus dolfinus approved these changes
@TiGrib TiGrib Awaiting requested review from TiGrib
@marashka marashka Awaiting requested review from marashka

Assignees

@IlyasDevelopment IlyasDevelopment

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IlyasDevelopment @dolfinus