Repository navigation
Put production DOMAINS in wrangler vars and drop keep_vars - #62
Closed
stc93025mn wants to merge 1 commit into
Closed
stc93025mn wants to merge 1 commit into
stc93025mn wants to merge 1 commit into
Conversation
Config owns the live plain var; change the list via PR. Routes stay dashboard-managed. Tests and local .dev.vars still use example domains. Co-authored-by: Mark Danielson <stc93025mn@users.noreply.github.com>
Member
Author
|
Closing: this public repo must not commit production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the live dashboard plain var
DOMAINSintowrangler.jsoncvarsand removekeep_vars. Config owns plains; the list changes via PR.Verified live Cloudflare setting (2026-09-28) for worker
wkd-proxy-worker:Changes
vars.DOMAINSwith that exact comma-separated list (no spaces).keep_vars: truefromwrangler.jsonc.DOMAINSlives in wrangler vars and is changed via PR. Routes stay dashboard-managed.Intentionally unchanged
wrangler secret put, no secret values.package.jsondeploy:cloudflareis stillwrangler deploy --keep-vars(Builds command left as-is). After this lands, that flag does not protect or overrideDOMAINSbecause config vars always apply.wrangler deploy.Why
keep_varsexistedGit history matches the hypothesis.
#55omitted exampleDOMAINSfrom Wrangler becausekeep_varsstill applies any vars present inwrangler.jsonc, and an earlier example list overwrote production.#54introducedkeep_varsso Builds would not clobber the dashboard list. Putting the live list in config is the intended end state;keep_varsis no longer needed forDOMAINS.Cloudflare docs treat the Wrangler file as the source of truth for plains.
keep_varsonly exists to preserve dashboard vars that are absent from config.Verification
Local checks on this branch (Node v22.14.0):
pnpm run typecheck— passpnpm run coverage— 17/17 tests pass, 100% statements/branches/functions/linespnpm run lint— passpnpm run format:check— passpnpm cf:check(wrangler deploy --dry-run) — pass; bindings includeenv.DOMAINSfrom wrangler vars; dry-run exited without deploying