fix: add DMWork to PLATFORMS registry in tools_config.py#2
Open
Jerry-Xin wants to merge 1 commit intoMLT-OSS:mainfrom
Open
fix: add DMWork to PLATFORMS registry in tools_config.py#2Jerry-Xin wants to merge 1 commit intoMLT-OSS:mainfrom
Jerry-Xin wants to merge 1 commit intoMLT-OSS:mainfrom
Conversation
When hermes-channel-dmwork adapter is installed and DMWork is configured as a platform, the gateway crashes with KeyError: 'dmwork' because the PLATFORMS dict in tools_config.py has no 'dmwork' entry. This adds the missing registration so DMWork platform toolsets resolve correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
hermes-channel-dmworkadapter is installed and DMWork is configured as a platform inconfig.yaml, the gateway crashes with:This happens because
hermes_cli/tools_config.pyhas aPLATFORMSdict that registers all known platforms, but DMWork is missing.Fix
Add the
dmworkentry to thePLATFORMSdict:Testing
Verified on a live deployment with
hermes-channel-dmworkadapter — gateway starts without KeyError and correctly resolves DMWork toolsets.