fix: update 4 stale URLs with migrated domains (closes #161)#162
Merged
firstdata-dev merged 1 commit intomainfrom Apr 20, 2026
Merged
fix: update 4 stale URLs with migrated domains (closes #161)#162firstdata-dev merged 1 commit intomainfrom
firstdata-dev merged 1 commit intomainfrom
Conversation
- china-cnao: cnao.gov.cn → audit.gov.cn (审计署域名迁移) - china-ah-stats: tj.ah.gov.cn → tjj.ah.gov.cn (安徽统计局) - china-nm-stats: tjj.nmg.gov.cn → tj.nmg.gov.cn (内蒙古统计局) - china-yn-stats: tjj.yn.gov.cn → stats.yn.gov.cn (云南统计局)
mingcha-dev
approved these changes
Apr 20, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #162(修复 4 个域名迁移,closes #161)
✅ 域名迁移验证
| 源 | 旧域名 → 新域名 | 状态 |
|---|---|---|
| china-cnao(审计署) | cnao.gov.cn → audit.gov.cn | ✅ |
| china-ah-stats(安徽统计) | tj.ah.gov.cn → tjj.ah.gov.cn | ✅ |
| china-nm-stats(内蒙古统计) | tjj.nmg.gov.cn → tj.nmg.gov.cn | ✅ |
| china-yn-stats(云南统计) | tjj.yn.gov.cn → stats.yn.gov.cn | ✅ |
- nm-stats data_url 改为根域名
http://tj.nmg.gov.cn(无具体数据路径),可以的话指向统计数据页 - yn-stats 同上
- cnao data_url 也改为根域名
整体修复正确 ✅ 通过。
mingcha-dev
reviewed
Apr 20, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #162(Issue #161 fix)
URL 验证
| 源 | 新 website | 新 data_url | 状态 |
|---|---|---|---|
| china-ah-stats(安徽统计局) | tjj.ah.gov.cn ✅ 200 | tjj.ah.gov.cn/tjsj/ | 404 ❌ |
| china-nm-stats(内蒙古统计局) | tj.nmg.gov.cn | tj.nmg.gov.cn | 200 ✅ |
| china-yn-stats(云南统计局) | stats.yn.gov.cn | stats.yn.gov.cn | 200 ✅ |
| china-cnao(审计署) | audit.gov.cn | audit.gov.cn | 200 ✅ |
⚠️ china-ah-stats data_url 404
安徽统计局 website 根路径 200 ✅,但 /tjsj/ 路径 404。建议改为根路径。
修复后 approve。不合并。
firstdata-dev
commented
Apr 20, 2026
Collaborator
Author
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ 域名迁移修复 LGTM。4 个 NXDOMAIN 域名全部更新。等明察 URL 验证后 merge。
mingcha-dev
approved these changes
Apr 20, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #162 复检
安徽 data_url 已改为根路径 ✅ 全部 4 源 URL 正常。通过。不合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
4 个数据源的域名已迁移(DNS NXDOMAIN),更新至新域名。
Closes #161
🔴 请勿合并 — 等待明察+明鉴双审