Fix: Replace Hardcoded Absolute Paths with argparse in BYOL/Inference Scripts#144
Open
Apprentice2907 wants to merge 4 commits intoML4SCI:mainfrom
Open
Fix: Replace Hardcoded Absolute Paths with argparse in BYOL/Inference Scripts#144Apprentice2907 wants to merge 4 commits intoML4SCI:mainfrom
Apprentice2907 wants to merge 4 commits intoML4SCI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143
Problem
Several Python scripts in the Transformers_Classification_DeepLense_Kartik_Sachdev
sub-project contained hardcoded absolute paths pointing to the original developer's
local machine. This made fine-tuning and inference completely non-functional for any
other contributor without manually editing source files.
Changes Made
The following files were updated to replace hardcoded paths with argparse CLI arguments:
finetune.py— replaced hardcodedsaved_model_pathanddevicefinetune_byol.py— replaced hardcodedsaved_model_path,finetuned_model_pathanddeviceinference.py— replaced hardcodedlog_dir,finetune_model_pathanddeviceself_supervised/examples/byol/finetune_byol.py— replaced hardcodedpretrained_model_path,finetuned_model_pathanddeviceself_supervised/examples/byol/inference_byol.py— replaced hardcodedlog_dir,finetune_model_pathanddeviceself_supervised/examples/byol/load_pretrained_byol.py— replaced hardcodedpretrained_model_path,finetuned_model_pathanddeviceHow to Run After Fix
Scripts now accept paths as command-line arguments, for example:
python inference.py --log_dir ./logger/2023-07-23 --finetune_model_path ./checkpoint/model.pt
Testing
Verified no hardcoded paths remain using:
grep -rn "/home|/content/drive|/root|/Users" --include="*.py" .