Refactor Classification Model_I and Model_II dataset loading for portability and deterministic class mapping#139
Open
Panchadip-128 wants to merge 3 commits intoML4SCI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the dataset loading logic in the Classification pipeline (Model_I and Model_II) to improve portability, reproducibility, and contributor usability.
Motivation
Previously:
These issues reduced portability and made onboarding difficult for new contributors.
Changes
Standardized dataset structure to:
root_dir/class_name/*.npy
Replaced ambiguous glob usage with:
os.path.join(root_dir, "", ".npy")
Added validation to raise a clear error if no .npy files are found.
Made class mapping deterministic using sorted class names to ensure consistent label indices across runs.
Improved path handling using os.path utilities for cross-platform compatibility.
Impact
This is purely a structural and usability improvement.
Expected Dataset Structure
Example:
data/
Model_I/
axion/
cdm/
no_sub/
Model_I_test/
axion/
cdm/
no_sub/