Fix cmake issues with external libraries#74
Conversation
| ${GLOG_INCLUDE_DIRS} | ||
| ${GTSAM_INCLUDE_DIR} | ||
| ${OPENGV_INCLUDE_DIR} | ||
| ${DBoW2_INCLUDE_DIRS} |
There was a problem hiding this comment.
@ruffsl I don't see why you need to put DBoW2 include dirs here, this should be already done when calling DBoW2::DBoW2 in target_link_libraries (are you using DBoW2 headers through Kimera?).
There was a problem hiding this comment.
I don't think that interface is working as you expect. My hunch is that the project was relying on and on finding the headers via the system global paths given the sketchy *sudo* make install
Lines 68 to 74 in a913c97
or depended on a erroneous limitation in legacy catkin for non-isolated devel space builds:
When using current build tools, each package must explicitly declare it's install steps given the use of sanitary/isolated builds. Thus every downstream package must similarly explicitly import the resources they need, as no cmake context it implicitly shared across workspace packages.
This fixes several cmake issues when using external libraries