backlog: correct my own #1131 amendment, strike a false limb in #1020, and file #1236 - #360
Merged
Merged
Conversation
…, and file #1236 FOUR EDITS, ONE COMMIT, because two passes publish an inconsistent ledger in between. 1. #1131 -- I LANDED A FALSE CLAIM IN fd2d832 AND THIS RETRACTS IT. I wrote that the step-up gate is "a partial answer to exactly that abuse surface, which nothing in the record credits". Both halves are wrong. (a) The record is NOT silent: cell 6.3.8 already describes "the only reset is administrator-initiated behind a step-up gate". So 6.1.1 OMITS it rather than the record LACKING it -- narrower, different defect. (b) THE SIGN IS INVERTED. 6.1.1 is about MALICIOUS lockout, and a stronger gate on the SOLE administrative remedy makes RECOVERY HARDER. It is a CONSTRAINT on the remedy, not a mitigating control. HOW I GOT IT WRONG, recorded because it is the reusable part: I verified the step-up EXISTS at auth_routes.py:757 -- that is real and still true. I did not verify its INTERPRETATION against the cell's axis; I inherited that from the report. Measuring the fact and adopting the framing are two acts and I performed one. This is section 16k's shape with me as the corrector: a correction arrives pre-framed as the more-examined claim, so it lands with more weight and less scrutiny. 2. #1131 -- the disclosure gap is not one parenthetical. docs/SECURITY.md:59 says "a single-admin deployment can't be locked out", flatly denying what the item is about, 1,485 lines BEFORE the known :1544 parenthetical -- and it is the one a reader greps for. Plus :741 and :782 on the same word. A fix that edits only :1544 leaves the contradiction that is read first. 3. #1020 -- struck a false limb its own 2026-08-11 amendment introduced. "The documented break-glass is a sealed file" is not an unlock path: _emit_bootstrap_admin writes it only for a NEWLY CREATED account gated on an empty users table, so it cannot recover an existing locked admin. And for a SOLE admin the "admin reset clears it" limb fails too -- that needs a second admin, and self-reset is refused. Only the 15-minute expiry survives, which is the lock lapsing rather than recovery. AN AMENDMENT WRITTEN TO CORRECT A PREMISE INTRODUCED A FALSE ONE. 4. #1236 FILED -- the sole-administrator dead end, as an AVAILABILITY defect rather than a documentation gap, and deliberately NOT riding #1131. If it rode #1131 a documentation edit would close the item while the defect went untracked. Five exits, each individually deliberate, all closing at once for a one-administrator site. Duplicate-checked before allocating: #1020 is adjacent (notifications cannot REACH the bootstrap admin) but is a different defect from #1236 (a locked admin cannot RECOVER), with different fixes. Both cite the same emailless-bootstrap root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only, four edits in one commit. #1131, #1020 and #1236 all OPEN.
1. I landed a false claim in
fd2d8325, and this retracts itI wrote that the step-up gate is "a partial answer to exactly that abuse surface, which nothing in the record credits." Both halves are wrong.
How it happened, because that is the reusable part: I verified the step-up exists at
auth_routes.py:757-- real, still true. I never verified its interpretation against the cell's axis; I inherited that from the report. Measuring the fact and adopting the framing are two acts, and I performed one.This is the shape the playbook already records with me as the corrector: a correction arrives pre-framed as the more-examined claim, so it lands with more weight and less scrutiny than the thing it replaces. The lane caught it by re-deriving the cell rather than accepting a summary.
2. The disclosure gap is not one parenthetical
docs/SECURITY.md:59reads "never auto-disabled, so a single-admin deployment can't be locked out" -- flatly denying what #1131 is about, 1,485 lines before the known:1544parenthetical, and the one a reader greps for. Two further collisions at:741and:782.A fix that edits only
:1544leaves the contradiction that is read first.3. #1020's own amendment introduced a false premise
Its rank row offers three limbs refuting "no administrative unlock path". The third -- "the documented break-glass is a sealed file" -- is not an unlock path:
_emit_bootstrap_adminwrites it only for a newly created account gated on an empty users table, so it cannot recover an existing locked admin.And for a sole administrator the second limb fails too: an admin reset needs a second admin, and self-reset is refused. Only the 15-minute expiry survives, which is the lock lapsing rather than a recovery path.
An amendment written to correct a premise introduced a false one.
4. #1236 filed -- and deliberately not riding #1131
The sole-administrator dead end is an availability defect in the shipped control, not a documentation gap. Five exits, each individually deliberate, all closing at once for a one-administrator site:
If it rode #1131, a documentation edit would close the item while the defect went untracked.
Duplicate-checked before allocating: #1020 is adjacent but different -- notifications cannot reach the bootstrap admin; #1236 is that a locked admin cannot recover. Different fixes, same emailless-bootstrap root.