Skip to content

PackageEditor: Compare package to installed package #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naNuke wants to merge 1 commit into
base: Beta
Choose a base branch
from
Open

PackageEditor: Compare package to installed package #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions LegendaryExplorer/LegendaryExplorer/Packages/SharedPackageTools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,66 @@ public static void ComparePackageToAnother(WPFBase wpfBase, Action<EntryStringPa
}
}

public static void ComparePackageToInstalledPackage(WPFBase wpfBase, Action<EntryStringPair> entryDoubleClickCallback, bool structuralCompare = false)
{
// no pcc no joy
if (wpfBase?.Pcc == null) return;

if (!wpfBase.Pcc.Game.IsMEGame())
{
MessageBox.Show(wpfBase, "Can only compare packages from the Original Trilogy or Legendary Edition.",
"Can't compare", MessageBoxButton.OK, MessageBoxImage.Error);
return;
}

Task.Run(() =>
{
wpfBase.BusyText = "Finding installed candidates...";
wpfBase.IsBusy = true;

CaseInsensitiveDictionary<string> dlcFiles = [];

string pccFileName = Path.GetFileName(wpfBase.Pcc.FilePath);
foreach (string file in MELoadedFiles.GetAllGameFiles(null, wpfBase.Pcc.Game))
{
string fileName = Path.GetFileName(file);
if (fileName == null) continue;
if (fileName != pccFileName) continue; // only files of same name
if (file == wpfBase.Pcc.FilePath) continue; // skip same file as current opened

string dlcFolder = file.Split(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar)
.FirstOrDefault(p => p.StartsWith("DLC_"));
dlcFolder ??= "basegame";

// save file
dlcFiles.Add(dlcFolder, file);
}

return dlcFiles;
}).ContinueWithOnUIThread(foundCandidates =>
{
wpfBase.IsBusy = false;
if (!foundCandidates.Result.Any())
{
MessageBox.Show(wpfBase, "Cannot find any candidates for this file!");
return;
}

var choice = InputComboBoxDialog.GetValue(wpfBase, "Choose installation source to compare to:",
"Installed file comparison", foundCandidates.Result.Keys, foundCandidates.Result.Keys.Last());
if (string.IsNullOrEmpty(choice)) return;

foundCandidates.Result.TryGetValue(choice, out string selectedFile);
if (selectedFile == null)
{
MessageBox.Show("Selected candidate not found in the lists! This is a bug", "OH NO");
return;
}

CompareToPackageWrapper(wpfBase, entryDoubleClickCallback, structuralCompare: structuralCompare, diskPath: selectedFile);
});
}

public static bool CanCompareToUnmodded(WPFBase wpfBase) => wpfBase.Pcc != null && wpfBase.Pcc.Game != MEGame.UDK && (!(wpfBase.Pcc.IsInBasegame() || wpfBase.Pcc.IsInOfficialDLC()) || ME3TweaksBackups.GetGameBackupPath(wpfBase.Pcc.Game) != null);

public static UnmoddedCandidatesLookup GetUnmoddedCandidatesForPackage(WPFBase wpfBase)
Expand Down
3 changes: 3 additions & 0 deletions LegendaryExplorer/LegendaryExplorer/Tools/PackageEditor/PackageEditorWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,11 @@
<MenuItem Header="Tools" Padding="4">
<MenuItem Header="Package file header info" ToolTip="View information stored in package header" Command="{Binding PackageHeaderViewerCommand}"/>
<MenuItem Header="LECL Data Editor" ToolTip="Edits metadata stored in this package that is used in mod development tools" Command="{Binding LECLEditorCommand}"/>
<MenuItem Header="Compare with another package (installed)" ToolTip="Compare another version of this package from installed packages in the game folder to see what exports and imports have changed" Command="{Binding CompareToInstalledCommand}"/>
<MenuItem Header="Compare with another package" ToolTip="Compare another version of this package to see what exports and imports have changed" Command="{Binding ComparePackagesCommand}"/>
<MenuItem Header="Compare with unmodded" ToolTip="Compare with the (hopefully) unmodded version of this package to see what exports and imports have changed" Command="{Binding CompareToUnmoddedCommand}"/>
<MenuItem Header="Structural Compare with another package (installed)" Command="{Binding StructuralCompareToInstalledCommand}"
ToolTip="Compare another version of this package from installed packages in the game folder to see what exports and imports have changed. This comparison method tries to match entries based on their paths, not their indexes." />
<MenuItem Header="Structural Compare with another package" Command="{Binding StructuralComparePackagesCommand}"
ToolTip="Compare another version of this package to see what exports and imports have changed. This comparison method tries to match entries based on their paths, not their indexes." />
<MenuItem Header="Structural Compare with unmodded" Command="{Binding StructuralCompareToUnmoddedCommand}"
Expand Down
6 changes: 5 additions & 1 deletion LegendaryExplorer/LegendaryExplorer/Tools/PackageEditor/PackageEditorWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ public bool ShowExperiments
public ICommand ForceReloadPackageCommand { get; set; }
public ICommand ComparePackagesCommand { get; set; }
public ICommand StructuralComparePackagesCommand { get; set; }
public ICommand CompareToInstalledCommand { get; set; }
public ICommand StructuralCompareToInstalledCommand { get; set; }
public ICommand OpenOtherVersionCommand { get; set; }
public ICommand OpenHighestMountedCommand { get; set; }
public ICommand CompareToUnmoddedCommand { get; set; }
Expand Down Expand Up @@ -264,6 +266,8 @@ private void LoadCommands()
StructuralCompareToUnmoddedCommand = new GenericCommand(() => SharedPackageTools.ComparePackageToUnmodded(this, entryDoubleClickToTreeview, true), () => SharedPackageTools.CanCompareToUnmodded(this));
ComparePackagesCommand = new GenericCommand(() => SharedPackageTools.ComparePackageToAnother(this, entryDoubleClickToTreeview), PackageIsLoaded);
StructuralComparePackagesCommand = new GenericCommand(() => SharedPackageTools.ComparePackageToAnother(this, entryDoubleClickToTreeview, true), PackageIsLoaded);
CompareToInstalledCommand = new GenericCommand(() => SharedPackageTools.ComparePackageToInstalledPackage(this, entryDoubleClickToTreeview), PackageIsLoaded);
StructuralCompareToInstalledCommand = new GenericCommand(() => SharedPackageTools.ComparePackageToInstalledPackage(this, entryDoubleClickToTreeview, true), PackageIsLoaded);
ExportAllDataCommand = new GenericCommand(ExportAllData, ExportIsSelected);
ExportBinaryDataCommand = new GenericCommand(ExportBinaryData, ExportIsSelected);
ImportAllDataCommand = new GenericCommand(ImportAllData, ExportIsSelected);
Expand Down Expand Up @@ -4686,4 +4690,4 @@ public void PropogateRecentsChange(string propogationSource, IEnumerable<Recents

public string Toolname => "PackageEditor";
}
}
}