Repository navigation
Conversation
Gate the remaining diagnostic flushes and verify guest calls, 64-bit timeouts and return values with logging on and off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LightEvent wrappers already gate their log lines behind
TOTK_WAIT_LOG. They still flush stderr after every wait and timed wait. Gate those two flushes as well. Guest calls, timeouts, and results use the same path with logging on or off.The focused fixture passed in both modes on the MD5Visual base. This changes logging overhead only. The task-ring stall remains open.