Repository navigation
Conversation
When the base and the cached view parent are both nil, pointer equality cannot revalidate the cached resource ID. Verify the missing-base case with the production Metal texture retirement probe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard type-view validation when the current Metal base is missing. A nil base could compare equal to the nil parent of an older standalone view, returning an ID after its base had retired.
The macOS OoT runtime built on this base and the texture retirement probe passed 35,022 checks with Metal validation. The fixture covers the missing-base case. This is a specific descriptor-lifetime fix; the in-game rendering artifacts still need a controlled repro.
The guard follows nxnative 0e4480d2 (MIT).