Repository navigation
Conversation
Both Russian and English opening runs request the English BWAV with a repeated separator before Stream. The title already chooses a supported voice locale. Normalize repeated separators for mounted OoT paths before read-only index lookup, including entry type and directory lookups, and keep rejecting traversal and backslashes. Keep the strict parser for other games and overlay manifests. Validated with 16 focused tests and the production RomFS probe against v131072, including byte-for-byte reads of the same opening voice asset through canonical and repeated-separator paths and 65 sampled files. Gameplay audibility is a separate check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
OoT can request voice streams with a repeated interior separator, for example
content://Voice/Resource//Stream/.... The RomFS parser already accepts repeated root separators. It rejected the interior separator before looking up the stream, so music and subtitles could play while the narrator was silent.Normalize separators for mounted OoT RomFS lookups. Keep rejecting traversal, backslashes and truncated paths. The strict parser still serves the other games and overlay manifests.
Validation
a2e9e756. The whole MD5Visual branch with only this patch has yet to be played. No iOS device test.