Draft
Conversation
Contributor
|
It'd be better if you expanded this out into a config (for both client and dedi server) rather than just nuking the hardcoded limits, especially for future console support. Won't merge this as-is, so changing to a draft. |
Contributor
Author
|
If we're seeking parity with Java edition, then we would need to remove the breeding limits. Unless the purpose of a config would be to continue to support lower-end hardware/keep legacy "features." |
Jave Edition already allows you to modify different game values through gameRules, so it wouldn't be too far from vanilla, Plus the config would be a good addition for servers to avoid lag and stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove breeding cap for all animals by setting limits to 0.
Changes
Previous Behavior
You would get the "This animal can't enter love mode..." message when the limits were reached.
Root Cause
Hardcoded limits in
MobCategory.h.New Behavior
No more limits.
Fix Implementation
I set all the breeding and spawn egg limits to 0 in
MobCategory.h.AI Use Disclosure
None.
Related Issues