Merged
Conversation
iggy doesnt like multiple shadow colors
|
yooo, cool, now i can make all things flashy |
itsRevela
pushed a commit
to itsRevela/LCE-Revelations
that referenced
this pull request
Apr 17, 2026
- Remove shadowcolor from font tags (Iggy doesn't support multiple) - Enforce HTML text mode on chat labels and jukebox - Move IDS translatable pattern matching into FormatChatMessage - Add §r (reset) color code support - Fix message truncation to count visible characters, skipping HTML tags - Fix CJK truncation using raw index instead of visible char count
veroxsity
pushed a commit
to veroxsity/MinecraftConsoles
that referenced
this pull request
Apr 18, 2026
* fix formatting in chat iggy doesnt like multiple shadow colors * enforce html labels * dont format before sending packet, client formats anyway * move translateables to chat format, restore original empty message results * fix crappy string cutoff * forgot a line on last commit, reset color support * restore function to strip styling from player messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes a bug with the chat formatting
Changes
Previous Behavior
color didnt apply after the first message
Root Cause
if the string is too long it wraps around and breaks styling, doesnt respect visible message length
New Behavior
color works correctly
Fix Implementation
added functions to get the visible message length instead of raw message length
enforced html labels in UIScene_HUD::handleReload()
moved translateables from the chat handle function to the chat message format function
added the missing "§r" but with no styling we just use it as another "§f" option and make the color white
AI Use Disclosure
no
Related Issues