Repository navigation
container.sh upgrade: keep data snapshots private - #107
Merged
Merged
Conversation
A snapshot directory made with plain mkdir -p and archives written under the helper's default umask left a full copy of the service's data readable by every local account. A new directory is now 0700, archives are written under umask 077 and chmod 600 afterwards (older ones too). Closes #104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104.
What changed
--snapshotsmay name a shared directory.umask 077. Afterwards the script runschmod 600on every<service>-*.tar.gzin the directory, which also covers snapshots made before this change.Why
Under the usual 022 umask, the snapshot directory was 0755 and the archive 0644. That left a full copy of the service's data readable by local accounts that cannot read the live volume under /var/lib/docker.
Verification
container/tests/upgrade_test.shasserts directory 700 and archive 600. On the old code (umask 022):FAIL: snapshot directory is 755, not 700; new code:PASS../run-tests:all 10 passed, 3 skipped.Not verified
chmod 600does not depend on the helper's umask.