Repository navigation
secrets env: keep the token and secret values off every child's argv - #100
Merged
Merged
Conversation
The token reached bws through the external env command's argv, and each project's secrets reached jq as a --argjson value; both are readable by other local accounts through /proc. Export the token in a subshell that execs bws, merge through stdin, and anchor the key check with \A...\z so a key ending in a newline is refused. The test now shims env and jq to log their argv. Closes #97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97.
What changed
bws_listexportsBWS_ACCESS_TOKENin a subshell that execsbws, instead of passing it as an argument to the externalenv.--vars) are merged by onejqreading both documents on stdin, instead of a--argjsonvalue.\A…\z; jq's$also matched before a trailing newline.Why
The script promises that the token and secret values never appear on a command line. Both were in a child's argv, which other local accounts can read through /proc.
Verification
secrets/tests/secrets_test.shnow shimsenvandjqto log their argv and fails if the token or a secret value appears; it also refuses a key ending in a newline.FAIL: 'machine-token-123' was on a child's command line.^…$anchor fails withFAIL: accepted: … --project newlinekey../run-tests:all 10 passed, 3 skipped(harden needs a disposable machine; two Windows-only suites).Not verified
bwsCLI (tests use the fake).