Skip to content

Add some more tests, tweak the guess value and add another escape hatch#31

Merged
Ickaser merged 1 commit into
LyoHUB:mainfrom
Ickaser:block-more-hangs
Jun 4, 2026
Merged

Add some more tests, tweak the guess value and add another escape hatch#31
Ickaser merged 1 commit into
LyoHUB:mainfrom
Ickaser:block-more-hangs

Conversation

@Ickaser

@Ickaser Ickaser commented Jun 4, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens the design_space.dry() edge-case handling and test coverage by adding scenarios that previously risked unstable iteration behavior and by introducing an “escape hatch” when computed product temperatures exceed the melting point.

Changes:

  • Added new design-space edge-case tests for high temperature/high pressure, “hot-dry” (melt-risk), and negative equipment capability behavior.
  • Improved numerical stability by reusing the previous Tsub as the next fsolve initial guess.
  • Added a warning + early-continue path that marks sublimation flux outputs as NaN when the computed maximum product temperature exceeds 0°C.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tests/test_design_space.py Adds edge-case regression tests around infeasible sublimation, melt-risk conditions, and negative equipment capability handling.
lyopronto/design_space.py Improves solver convergence behavior and adds a melt-risk “escape hatch” that warns and returns NaN flux metrics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lyopronto/design_space.py
Comment thread tests/test_design_space.py
Comment thread tests/test_design_space.py
@Ickaser Ickaser merged commit 8b93cfb into LyoHUB:main Jun 4, 2026
3 checks passed
@Ickaser Ickaser deleted the block-more-hangs branch June 4, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants