Repository navigation
Conversation
SimulationSettings read save_planes=80 as one plane at z = 80 m. A bare integer is now refused with a pointer to counted_save_planes, the new public helper that places a count as n_save does (z = 0 counted, the end included); n_save uses it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
On the object routes a settings table's save_planes = 80 is now 80 planes over grid.length, counting the entrance, placed with counted_save_planes; check() warns when a listed last plane is not grid.length. TOML keeps the count as written and the Python export writes counted_save_planes(grid.length, 80) (#533). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
Documentation build overview
11 files changed ·
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Nov 15, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the radial, free and planar routes, a recipe's
save_planes = 80used to passcheck()and mean one plane at z = 80 m. The maintainer decided that an integer is a count of planes overgrid.length.n_saveplaces them,linspace(0, length, count)[1:]. The count includes z = 0, the last plane is atgrid.length, and the minimum is 2. A newcounted_save_planes(length, count)insolprop.driver.settingsholds the rule, andn_savenow uses it too, so the two cannot drift apart.SimulationSettingsdeclaressave_planesas a counted keyword (Factory.counts), so a bare TOML integer there is placed overcontext.grid.length. A bad count is aRecipeErroratsettings.save_planes.SimulationSettings(save_planes=80)now refuses a bare integer or bool, and the message points atcounted_save_planes. A lone float is still one position in metres, as before.Recipe.check()warns, rather than refuses, when a listed last plane differs fromgrid.length(relative tolerance 1e-9).80as written. The Python export writescounted_save_planes(grid.length, 80).running.mdandrecipes.mddocument both forms, and there is a changelog fragment.Tests: the regression (80 planes ending exactly at
grid.length, hashing like the Python call), the refusals, the warning, the missing-grid case and the round trip. Settings and recipe modules plus the three object-route driver tests: 751 passed, with runtime type checks on and off.To confirm before marking ready:
counted_save_planesis added tosolprop.driver.settings.__all__.int, which basedpyright flags at 35 call sites. Python code passingsave_planes=2to mean 2 m now errors; none was found in src, tests or docs.Known gap: the GUI's "Saved planes" field (
even_planes) counts positions without the entrance, and it shows an integer recipe as missing. It doesn't crash, and it is unchanged here.Closes #533
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH