Repository navigation
fix(benchmarks): key history by build profile and admit dirty native builds - #838
Merged
Merged
Conversation
…builds Rows now compare only within one native build profile (the first field of native_build), so a local build after the release's wheel starts a new series instead of reading as a speed-up; a toolchain change inside the wheel still compares. imported_elsewhere strips the build's +dirty stamp before asking git, admits it with --allow-dirty (marking the rows dirty) and otherwise refuses by naming the modified tree. CMake's dirty check ignores benchmarks/history, which one checkout may modify to record several runs. Refs #138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jtravs
marked this pull request as ready for review
November 15, 2026 17:55
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparability key holds the build profile alone, as #138 recommended and the maintainer confirmed. With it, a compiler or BLAS change inside the wheel still compares, while a local build does not.
Part 1, the key.
benchmarks/history.pycomparable()now includes the build profile: the first;field of the existingnative_buildcolumn (distribution,localorreference).Part 2, dirty builds.
benchmarks/track.pygainsnative_build_commit(), which strips+dirty, and passes--allow-dirtytoimported_elsewhere.dirty=1with the barenative_commit, and the staleness check still applies.+dirtyagain.native/CMakeLists.txt's dirty check now excludesbenchmarks/history. A probe undercmake -Pgave:native/file modified too → 1.docs/dev/benchmarking.mdis updated to match.Tests: two regression tests in
tests/test_benchmark_track.py, using the issue's reproduction (shared_previous0 across profiles) and the dirty admit/refuse cases. 34 passed.Still open in #138: the "page says one thing" item (CPU rows time the wheel), and the "Also" items: misaligned rows from
history.append, and the stale version label.Refs #138
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH