Skip to content

Native structure and bound structs (PR-5) - #770

Merged
jtravs merged 28 commits into
mainfrom
refactor/native-structure-seam
Nov 12, 2026
Merged

jtravs merged 28 commits into
mainfrom
refactor/native-structure-seam

Conversation

@jtravs

@jtravs jtravs commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

PR-5 of the lean-codebase plan: the native helpers, the bound problem struct and the workspace forwarders (first half), then the split of general.cpp, close() by destruction, the decomposition of long cold functions and the dead-code removal (second half, steps 4–7, below). Stacked on feature/two-backends-binary64, with chore/native-tooling merged in. It will be retargeted to main later.

Maintainer decision (2026-11-12): keep the bound Problem, but do not bind the other structs (march, watch, Runge-Kutta, session, transverse and stage tables stay dicts) and do not split NB_MODULE for its own sake: binding turned out not to save lines. What remains is aimed at real line reduction and structure.

What changed

  • Messages. refuse<Error>(parts...) and concat(parts...) (include/solprop_native/refuse.hpp) replace about 40 hand-built "..." + std::to_string(n) refusals. Every message keeps its exact text.
  • Build facts. include/solprop_native/build.hpp defines cuda, hip, device, host and openmp. Where both branches compile in every build, #if blocks become constants or if constexpr. Blocks that name device-only or host-only facilities keep their #if, and so does the Adams flow guard that nvcc needs.
  • Width dispatch. dispatch_among and dispatch_width (include/solprop_native/dispatch.hpp) replace the four switch ladders: the band filter, the modal projection lanes, and the device Adams prediction and element.
  • Forwarders. The private member template GeneralState::with_team(&GeneralWorkspace::f, args...) replaces the bodies of the 66 forwarders that opened the CPU team scope by hand. The declarations stay, because the pImpl keeps the workspace class out of the strict units.
  • Bound problem. native::Problem's 161 fields are nested in 14 groups: dims, grid, spatial, flux, stepper, linear, absorber, transform, kerr, plasma, raman, general, flow and dispersive. Each group is bound with nb::class_, and FieldFamily with nb::enum_.
    • Vector fields take only exact NumPy arrays (float64, complex128, uint64 or bool, C-contiguous). Fields whose count is laid out beside them also require a fixed rank. Anything else is refused, and the message names the field.
    • Problem::validate() holds problem_from's presence and extent rules, with the same messages.
    • The adapter's _lower(problem, request, plan) replaces _native_problem, its dict and its payload helpers.
    • Check: before the dict path was removed, a temporary comparison lowered 851 problems from the native test suites. Every field matched the old dict bit for bit. The problems covered plasma, envelope, Raman, general modal, coupled flow, dispersive, free, planar and low-storage cases.
    • Tests: they now set struct fields instead of dict keys. No assertion or match= was removed and no tolerance changed.

Hot-path commits (for the A/B)

  • 41f53f3c dispatch_width: the band filter (host and device), the modal projection lanes, and the device Adams prediction and element.
  • 9b6eec2f build facts: the Adams block width, the accepted-step fence and the band league. The others are cold predicates.
  • f7f5ddc2 with_team: every GeneralState call, trial_step and the Adams trials included, goes through std::invoke.
  • 2da322d9 bound problem: a mechanical rename of problem_.x to problem_.group.x throughout general.cpp, kernels included.
  • d8d3af10 refuse: the cold throw branches of the stage-table and z-table lookups and of prepare_trial.

Every commit is meant to give bitwise-identical results, field_difference 0.

Sizes

tools/size_report.py covers src/solprop, which this PR does not touch. For native/ (git diff --shortstat from the base: 40 files, +4839 / −4316):

before after
C++ (src, include, tests/native) 56,448 56,619
adapter Python 13,864 13,877
_core.pyi 715 946
native Python tests 13,567 13,675

The plan's savings are not reached yet. Most of them were to come from the part of step 2 that this PR leaves open (below).

Not done (step 2 remainder, now dropped by the decision above)

  • Binding the march, watch, Runge-Kutta, session, transverse and stage-table structs with nb::class_, in place of the *_from and *_to dict conversions. Their dicts are produced and read in solprop as well as in the adapter.
  • Splitting NB_MODULE into bind_state.cpp, bind_session.cpp and bind_build.cpp.
  • Turning the BoundState lambdas into .def(&BoundState::f, nb::call_guard<...>()). Most lambdas convert NumPy inputs before releasing the GIL, so they first need an exact-array argument type.
  • Generating the whole _core.pyi with nanobind.stubgen: while most of the seam is untyped dicts, a generated stub would type them as bare dict and break strict typing in the adapter. The bound problem's part is now generated (second half, below).

Second half: structure (steps 4–7)

  • Stub (ae3918f9). native/scripts/problem_stub.py writes the FieldFamily/Problem part of _core.pyi from nanobind.stubgen, keeping each setter's type as a plain attribute so strict pyright reads the adapter's assignments as before; the lint stage runs it with --check. The output equals the hand-written section (only the markers were added).

  • Split (bea5d7b9). src/general.cpp (18.3k lines) becomes src/general/: kernels.hpp (device helpers, kernel functors, view and plan types), workspace.hpp (the class), and checks.cpp, setup.cpp (constructor, allocate, upload, plans, ledger), trial.cpp (the hot set in one unit: trials, stages, responses, band and envelope plasma, Adams, low storage, split step), statistics.cpp (statistics, monitor and edge readings) and state.cpp (transfers, GeneralState). A pure move (the line multiset is unchanged apart from namespace lines, inline on eight shared plain helpers and the out-of-line constructor). The helpers leave the unnamed namespace for solprop_native::general, found through a using-directive, because the class's fields and member signatures name them across units. Both headers #error under SOLPROP_NATIVE_STRICT_TU, which CMake now sets on the ten strict sources (one list for the definition and the -ffp-contract=off option). No function moved between strict and contracting units: the strict sources are untouched and src/general/ holds no strict namespace; ci/check_strict_fma.py on the built extension: 173 strict functions, none fused. The licence test now names the helpers' new files (it had silently skipped them).

  • Destruction (13aa7a63, 1fa55177, ed006584). GeneralWorkspace::close() (339 lines) becomes ~GeneralWorkspace() { execution_space_.fence(); }. Audit: all 37 plan constructions name only views declared before the plan, so each plan is destroyed before its views, and the execution instances are declared after the pools. GeneralState::close() destroys the workspace; with_team refuses a closed state, replacing 40 require_open() calls; the noexcept readers read nothing once closed. The same applies to GeneralModalSource, CoupledFlowAction, the three dispersive responses, DispersiveWeights and FarFieldPass: each destructor fences, and their close(), closed_ and closed refusals go (they were only closed by their owner). Behaviour change: a closed GeneralState now refuses memory_ledger() instead of returning zeros; Python's bound state already refused it once closed, and one GoogleTest assertion follows.

  • Ledger (bf847391). bytes(views...) and reserved(vectors...) replace the per-view multipliers; host problem arrays are listed by Problem group. Every ledger entry is unchanged on the 21 benchmark configurations except the measured plan heap growth.

  • Long functions (2ccc83b3, 6966802e). require_general_problem becomes six checks by concern, the separable geometry's extents and finiteness rules as tables (order and messages unchanged); allocate() (914 lines) hands eleven blocks to members; plan() its transverse, Raman and split-step plans; statistics() its energy, windowed-energy, intensity and plasma passes. readability-function-size is on at LineThreshold: 300. Left whole with NOLINTNEXTLINE(readability-function-size): adams_exponential_trial and team_band_plasma_column (hot path, split pending an A/B) and NB_MODULE (the module's one binding table).

  • Dead C++ (4cc6908f). Of the run 43171495302 coverage report's unexecuted functions, every one but these has a caller in some build (device branches, solprop's tests through the bindings, native test entry points). Deleted: field_family in bindings.cpp (unused since the bound problem; a -Wunused-function error under -Werror), GeneralModalSource::delayed_fft_provider, CoupledFlowAction::n_sections and full_route, and the device graph region's replays()/captures()/disabled() readers with the two counters only they read.

  • Review fixes (b9f8f9a5, a7874a8c, aefa7d03, bb3eca14). The coverage build's source record now hashes src/general/'s headers. The bound problem had loosened problem_from's layout checks to size checks: the bindings now record each Linear, Plasma and Raman array's shape and Problem::validate holds it to its counts again (fixed terms rank two or three with n_phi_terms/n_prefactor_terms rows; raman_undamped (n_terms, 2 n_to); raman_tensor_weights (n_terms, 2); rate_coefficients (4, n_intervals); envelope rules (n_channels, 4, 512)), with the old messages, and the adapter lays the fixed terms out as (n_terms, rows, n_omega) as before. Each restored check has a test that a transposed or miscounted table with the right element count is refused by name. The stub says array fields are copied in and out. The open documents point at src/general/.

Hot-TU commits (second half, for the A/B)

  • bea5d7b9 the split: the hot set keeps one unit, but the shared helpers change linkage (unnamed namespace to solprop_native::general) and cold members leave the hot unit.
  • 6ed5a296 whitespace in kernels.hpp only.
  • 13aa7a63 removes require_open() from 24 trial.cpp entry points (the check moves to GeneralState::with_team).
  • 1fa55177 removes closed-state branches from GeneralModalSource::evaluate/set_weights/combine and CoupledFlowAction::set_trial/form_actions/set_actions/actions_to_host.
  • 4cc6908f removes two counter increments from the device graph region's replay and capture paths.
  • 6966802e adds only NOLINT comments to trial.cpp. 2ccc83b3, bf847391, ed006584, ba70b224, 464c2ad9 are cold or comments.

Bitwise check here: 21 configurations (11 benchmark cases, default and RK, 0.1 of their length, 4 threads) hashed final fields and statistics after each step: identical to the base build at every step, with SOLPROP_FFTW_PLAN=estimate SOLPROP_CALIBRATION=off. Without estimate, rebuilding the unchanged base gave different argon_blueshift_envelope and kerr_beam_192 fields: their measured FFTW plans are re-chosen per build, so a field_difference of 0 on envelope cases needs estimated (or shared) plans.

Line counts per step (native/)

step src include tests/native adapter .py _core.pyi scripts/*.py
start (ccf8d8d5) 34,425 11,483 10,711 13,877 946 190
stub 0 0 0 0 +4 +69
split +86 0 0 0 0 0
destruction and ledger −668 −12 −2 0 0 0
long functions +181 0 0 0 0 0
dead code −14 −13 0 0 0 0
end (464c2ad9) 34,010 11,458 10,709 13,877 950 259

The decomposition adds function headers and comments; the real savings are the destructors (about −680). The plan's 3.5–5.5k C++ is not reached: most of it was to come from binding the other structs, which the decision above drops.

Verification, first half (Mac, Apple Clang via Homebrew LLVM, editable Release build, OpenMP CPU)

  • Native pytest modules, run with -n 4: test_api_contract, test_backend, test_envelope_plasma, test_mixtures, test_execution, test_band_plasma, test_session_failure, test_dispersive, test_free, test_envelope_statistics_refusal, test_coupled_flow, test_general_modal, test_radial, test_planning, test_raman_tail and test_batch.
  • Native parity modules from tests/backends, also with -n 4: low storage, planar, far field, every statistic, dispersive Kerr, held plasma, node chunk, phi moments, z table, stage tables, march admission, rk/march traces, widths. Flow sessions and marches, resume history and helpers from tests/driver and tests/test_helpers.py ran too.
  • GoogleTest in a Debug build: passed.
  • ruff, the native pyright configuration (0 errors) and clang-format.
  • clang-tidy on the changed sources. One finding was fixed in its own commit.
  • Two local failures happen on this Mac without the change too, so they are not counted against it:
    • test_public_surface_is_exact: an uncommitted tree gives a .dYYYYMMDD version suffix.
    • test_response_column_boundary_preserves_full_and_tail_windows[19]: it fails the same way on main here.
  • Not run here: CUDA and HIP compiles. The dispatch lambdas and the if constexpr facts are compiled on devices for the first time in the device-compile lanes.

Verification, second half (Mac, Homebrew Clang 23.1, editable Release build with IPO, OpenMP CPU)

  • The bitwise check above after every step; check_build() fresh; check_strict_fma.py clean.
  • Native pytest with -n 4: test_api_contract, test_backend, test_session_failure, test_general_modal, test_coupled_flow, test_dispersive, test_planning, test_store, test_envelope_statistics_refusal, test_band_statistics_per_node, test_free, test_radial; parity modules: every statistic, planar statistics, edge reading, widths, far field (three), dispersive routes, low storage, held plasma, floating-point licence, march and RK rows.
  • GoogleTest (Debug, -Werror): 235 passed, 8 skipped.
  • clang-tidy (full) on every changed source; the function-size check alone over every native source and test; clang-format, ruff.
  • The only local failure is test_public_surface_is_exact (the editable versions differ by commit).
  • Not run here: CUDA and HIP compiles (the destructors, the device graph counters and the file-scope statistics aliases are compiled on devices first in the device-compile lanes), the full suites (CI).

🤖 Generated with Claude Code

https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3

jtravs and others added 8 commits November 12, 2026 09:05
refuse<Error>(parts...) and concat(parts...) (include/solprop_native/
refuse.hpp) replace the hand-built `"..." + std::to_string(n) + "..."`
messages. Numbers keep std::to_string's text, so every message is
byte-identical. The march's and the watch's own policy helpers are named
refuse_policy so that they no longer shadow it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
include/solprop_native/build.hpp holds cuda, hip, device, host and
openmp as inline constexpr bools. The #if blocks whose branches both
compile in every build become constants or if constexpr: the crossing's
device test, the real-signal switch, the register plane, the host pack
layout, the Adams block width, the accepted-step fence, the band league
and four host-only eligibility predicates. Blocks that name a device- or
host-only facility keep their #if.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
dispatch_among<Values...> and dispatch_width<First, Last>
(include/solprop_native/dispatch.hpp) turn a run-time extent into a
compile-time one through a forced-inline comparison chain, which the
compilers fold back into the switch. They replace the band filter's
half-width ladder, the modal projection's lane ladder and the device
Adams prediction's and element's width ladders.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
A private member template, GeneralState::with_team(function, arguments...),
opens the workspace's CPU team scope and invokes the workspace's member
on it; the 66 forwarders that opened the scope by hand become one call
each. It is defined and instantiated in general.cpp alone, so the pImpl
stays the firewall that keeps the workspace class from the strict units.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
clang-tidy's readability-avoid-return-with-void-value: the three void
overloads no longer return their member's void, and with_team, which
returns whatever its member returns, says why it may.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
native::Problem's 161 fields are grouped into sub-aggregates (dims, grid,
spatial, flux, stepper, linear, absorber, transform, kerr, plasma, raman,
general, flow, dispersive), every access renamed mechanically. The
extension binds them with nb::class_ (FieldFamily with nb::enum_): a
scalar field reads and writes as itself, a vector field as an exact NumPy
array, float64, complex128, uint64 or bool, C-contiguous, of a declared
rank where its count is laid out beside it, refused otherwise with the
field's name. Problem::validate() keeps problem_from's presence and extent
rules and their messages, and the CPU execution and FFT planning records
still cross as dicts.

The adapter's _lower(problem, request, plan) fills the structs in place of
_native_problem's dict and its payload helpers; a lowering of 851 problems
from the native test suites matched the old dict field for field, bit for
bit, before the old path was removed. Tests address the struct fields
instead of dict keys, with every assertion and match kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
The bound struct's fields read and write the same types, so the stub
declares each as an attribute instead of a property and its setter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
@read-the-docs-community

read-the-docs-community Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

jtravs and others added 16 commits November 12, 2026 10:38
scripts/problem_stub.py keeps stubgen's setter types as plain attributes,
so strict pyright reads the adapter's assignments as before; the lint
stage checks that the committed section is fresh.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
A pure move: kernels.hpp holds the shared device helpers and types,
workspace.hpp the class (its constructor now out of line in setup.cpp),
and checks, setup, trial (the hot set, one unit), statistics and state
hold the members. The helpers move from an unnamed namespace to
solprop_native::general, found through a using-directive. Both headers
refuse inclusion from the strict units, which CMake now marks with
SOLPROP_NATIVE_STRICT_TU; the licence test follows the helpers' files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
GeneralWorkspace's 339-line close() becomes a destructor that fences:
every plan is declared after the views it is built on, and the execution
instances after the pools, so member destruction releases them in the
order close() did. GeneralState::close() destroys the workspace, and
with_team refuses a closed state, in place of the workspace's 40
require_open() calls; the noexcept readers read nothing once closed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
The general modal source, the coupled flow, the three dispersive
responses and the far-field pass were only ever closed by their owner's
close() or their own destructor: each destructor now fences and lets its
members go (plans are declared after the views they are built on), and
their close(), closed_ flags and closed refusals go. DispersiveWeights
keeps its default destructor. Two native tests no longer close a part
by hand before it leaves scope.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
Each entry sums its views' elements times their own element size, and
the host problem arrays are listed by the problem's nested groups: the
same numbers (every entry but the measured plan growth is unchanged on
the benchmark cases), without a multiplier per view to keep in step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
With close() destroying the workspace, a closed GeneralState reads
nothing: the dispersive test asserts the refusal where it asserted a
zero row (Python's bound state already refused the read once closed).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
require_general_problem becomes six checks by concern, the separable
geometry's extents and finiteness rules as tables; allocate() hands its
separable, low-storage, statistics, Raman, transform, forward-row,
absorber, plasma, split-step and part allocations to members; plan()
its transverse, Raman and split-step plans; statistics() its energy,
windowed energy, intensity and plasma passes, with the absent offset and
the device team aliases at file scope. Moves only: the order of every
check, allocation and kernel is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
The two hot kernels above it, adams_exponential_trial and
team_band_plasma_column, and the module's binding table carry a NOLINT
with their reason; the hot ones wait for an A/B before any split.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
From the native-deep coverage run's unexecuted functions, those with no
caller in any source, header, test or #if branch: the bindings'
field_family (left unused by the bound Problem, and a -Wunused-function
error under -Werror), GeneralModalSource::delayed_fft_provider,
CoupledFlowAction::n_sections and full_route, and the device graph
region's replays, captures and disabled readers with the two counters
only they read. Every other unexecuted function has a caller: a device
branch, solprop's own tests through the bindings, or a native test
entry point.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
The coverage source record and its configure dependencies globbed
src/*.cpp and include/*.hpp alone, so an edit to kernels.hpp or
workspace.hpp left the record unchanged; it now takes the source
digest's set.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
The bound problem kept a field's elements alone, so Problem::validate
checked raman_undamped, raman_tensor_weights, rate_coefficients and the
envelope rules by size, and the fixed terms not at all: a transposed
table with the right element count passed. The bindings now record the
shape each Linear, Plasma and Raman array arrives with, and validate
holds it to the layout its counts give, with the old messages (the
fixed terms rank two or three, their leading extent the term count).
The adapter lays the fixed terms out as (n_terms, rows, n_omega) again,
as before the bound problem. Each restored check has a test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
Base automatically changed from feature/two-backends-binary64 to main November 12, 2026 13:26
jtravs and others added 2 commits November 12, 2026 13:54
The build-facts change had made adams_block `build::device ? 1 :
adams_lane_width`, but adams_lane_width exists only on a host build, so
CUDA and HIP refused it, and HIP then refused every device use of the
non-constant block. It is the #if constant it was. The two device-only
width dispatches in the elementwise Adams trial go back to their
switches as well: the CUDA compile of this file also failed inside
nvcc, and device-only code is not compiled before CI. The host build
is unchanged (bitwise on the benchmark cases).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
With trial.cpp fixed, CUDA 12.8's front end refused bindings.cpp:
array_of's return type and two aliases relied on C++20's implicit
typename, and nvcc took ExactArray<Element> for an incomplete type.
Each carries its typename again, with a NOLINT naming why.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jtravs
jtravs marked this pull request as ready for review November 12, 2026 17:26
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T17:35:06.504393Z 7d058ba New commits
🔒 Security Review ✅ Completed 2026-11-12T17:36:59.283084Z 7d058ba New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jtravs
jtravs merged commit 33172a5 into main Nov 12, 2026
70 of 71 checks passed
@jtravs
jtravs deleted the refactor/native-structure-seam branch November 12, 2026 19:35
jtravs added a commit that referenced this pull request Nov 12, 2026
Brings in #770, #768 and #774 (main 33172a5). The TDSE changes of this
branch move with #768's split of simulation.py: the numpy_ref-only rule of
_admit_tdse_execution is gone from driver/settings.py, and driver/tdse_run.py
takes the stop flag to the binding, the installed provider's revision for
the consistency gate, no provider_pin in the archive context, and auto
resolving to native. ADR-077 keeps main's text with ADR-078's amendment
note; layers.svg is redrawn with docs/dev/figures/build.py. A docstring line
in test_tdse_hacc_installed.py is rewrapped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HAYtF5P9QqEd3HQx3WJkA3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant