Skip to content

The fixed-step scaffold's n_save does not count the entrance #856

Open

Description

@jtravs

src/solprop/driver/scaffold.py, the fixed-step scaffold, has its own n_save, and its count does not include the entrance. SEP 51 (#851) gives n_save one meaning on every Simulation route: evenly spaced observations over [initial_z, length], both ends included. The scaffold is a separate tool and was left out of SEP 51's scope, so the same name now means two different counts. Decide whether to align the scaffold with SEP 51 or to rename its parameter.

Activity

  1. added 2 commits that reference this issue on Nov 16, 2026
    47d8c52
    e0e1a97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions