You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The fixed-step scaffold's n_save does not count the entrance #856
src/solprop/driver/scaffold.py, the fixed-step scaffold, has its own n_save, and its count does not include the entrance. SEP 51 (#851) gives n_save one meaning on every Simulation route: evenly spaced observations over [initial_z, length], both ends included. The scaffold is a separate tool and was left out of SEP 51's scope, so the same name now means two different counts. Decide whether to align the scaffold with SEP 51 or to rename its parameter.
Activity
Give the scaffold's n_save SEP 51's meaning; poll the heartbeat test
Give the scaffold's n_save SEP 51's meaning; poll the heartbeat test