Skip to content

Length-dependent defaults beyond the absorber: modal loss limit, boundary-monitor spacing, walk-off warning #855

Open

Description

@jtravs

Found while implementing SEP 51 (#851), where a run now always ends at its grid's length. A test that used to run a short window of a longer grid now cuts the grid at the run's end. SEP 51 §3 lists the default absorber reference length (grid.length / boundary_N) and a keyword route's default steps and profiles as the setup that depends on grid.length. Three more defaults also read it:

  • LossPolicy.limit(grid.length) in src/solprop/linear.py clamps modal attenuation;
  • the boundary monitor's quiet-window spacing is grid.length / CHECKS;
  • the walk-off warning integrates over grid.length.

None of these moved a test in #851, but none is pinned when a test's grid is shortened. They should be documented beside the absorber in the manual (and in docs/dev/ where the absorber's length dependence is described). Each should also be checked: should it follow the run's length, or a length the caller can pin, the way boundary_length pins the absorber's?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions