Skip to content

Strict-FP check: cover local helpers in strict translation units #777

Open

Description

@jtravs

`native/ci/check_strict_fma.py` checks the wheel's disassembly for fused multiply-adds inside strict functions.

SEP 49's PR (#771) found that the distribution wheel is stripped, so `objdump -d` labels only exported functions. The old check charged everything up to the next label to the preceding strict function, which produced a false positive: link-time optimisation had placed contracting dispersive kernels right after `march::reached`. The fix bounds each strict function by its own symbol size.

That leaves a gap the old check covered only by accident: local helpers (anonymous-namespace or static functions) defined in strict translation units have no symbols in the stripped wheel, so nothing checks them.

Proposal: also run the check on the strict TUs' object files from the build tree, before linking. Object files keep a full `.symtab`, so every function in a strict TU, local helpers included, can be checked. One way: a CMake test target or a CI step after the wheel build that lists the objects of the sources carrying `SOLPROP_NATIVE_STRICT_TU`. Keep the wheel-level check too, since it catches LTO and COMDAT surprises after the link.

🤖 Generated with Claude Code

Activity

  1. added a commit that references this issue on Nov 13, 2026
  2. added
    testingTests, test tiers and CI coverage
    area: nativeThe native backend, threading and FFT planning
    on Nov 13, 2026
  3. jtravs commented on Nov 13, 2026

    @jtravs
    ContributorAuthor

    Picked up by the issue-fixing session (branch test/ci-hardening-494, with #494, #612, #777).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: nativeThe native backend, threading and FFT planningpriority: lowWorth doing, no hurrytestingTests, test tiers and CI coverage

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions