You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Correct static typing in DF32 Adams and history qualification tests #756
The first full static CI run of the reviewed DF32 Adams bridge batch (118e600c, PR #611) fails basedpyright on the new qualification tests. Numerical managed-runtime runs passed, but the submitted test helpers infer str/int from defaults that also accept None, backend-specific assertions use the generic RunSession protocol, nested execution counters remain typed as object, and one final group batch is only assigned inside a loop. A history ownership test also dereferences an optional snapshot without an explicit narrowing assertion.
Reproduction
Run uv run basedpyright tests/backends/julia/test_cpu_df32_adams.py tests/backends/julia/test_history.py. CI reports 15 errors across those files; the failing static job is 130595305182.
Correction and acceptance
Declare genuinely optional helper inputs, assert concrete Julia-session and mapping/snapshot invariants before backend-specific access, and retain group batches explicitly. Preserve every numerical input, envelope, failure assertion and test count. The focused type check and directly affected tests must pass; this is not a production admission or numerical-policy change.
Closing: the maintainer withdrew SEP 48 (the Julia backend) on 2026-11-11. C++/Kokkos stays the engine, and solprop has exactly two backends, native and numpy_ref (ADR-077, recorded in #763). This issue concerns only the Julia backend, its package, bridge or CI, so it no longer applies.
Activity
Narrow DF32 qualification helper types and asserted records (#756)
jtravs commentedon Nov 12, 2026
Closing: the maintainer withdrew SEP 48 (the Julia backend) on 2026-11-11. C++/Kokkos stays the engine, and solprop has exactly two backends, native and numpy_ref (ADR-077, recorded in #763). This issue concerns only the Julia backend, its package, bridge or CI, so it no longer applies.