Skip to content

Correct static typing in DF32 Adams and history qualification tests #756

Closed as not planned

Description

@jtravs

What happens

The first full static CI run of the reviewed DF32 Adams bridge batch (118e600c, PR #611) fails basedpyright on the new qualification tests. Numerical managed-runtime runs passed, but the submitted test helpers infer str/int from defaults that also accept None, backend-specific assertions use the generic RunSession protocol, nested execution counters remain typed as object, and one final group batch is only assigned inside a loop. A history ownership test also dereferences an optional snapshot without an explicit narrowing assertion.

Reproduction

Run uv run basedpyright tests/backends/julia/test_cpu_df32_adams.py tests/backends/julia/test_history.py. CI reports 15 errors across those files; the failing static job is 130595305182.

Correction and acceptance

Declare genuinely optional helper inputs, assert concrete Julia-session and mapping/snapshot invariants before backend-specific access, and retain group batches explicitly. Preserve every numerical input, envelope, failure assertion and test count. The focused type check and directly affected tests must pass; this is not a production admission or numerical-policy change.

Related: SEP 48 #608 / implementation #611.

Activity

  1. added
    testingTests, test tiers and CI coverage
    priority: mediumReal work that should not wait long
    on Nov 11, 2026
  2. jtravs commented on Nov 12, 2026

    @jtravs
    ContributorAuthor

    Closing: the maintainer withdrew SEP 48 (the Julia backend) on 2026-11-11. C++/Kokkos stays the engine, and solprop has exactly two backends, native and numpy_ref (ADR-077, recorded in #763). This issue concerns only the Julia backend, its package, bridge or CI, so it no longer applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: mediumReal work that should not wait longtestingTests, test tiers and CI coverage

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions