Repository navigation
Add BBO's ordinary and extraordinary Sellmeier formulas (Tamošauskas 2018) - #48
Open
chrisbrahms wants to merge 6 commits into
Open
chrisbrahms wants to merge 6 commits into
chrisbrahms wants to merge 6 commits into
Conversation
…2018) Eq. (1) of Tamošauskas et al., Opt. Mater. Express 8, 1410 (2018), both rays over 188 nm-5.2 um, as the recommended models of BBO. They reproduce the type I SHG angle of 800 nm (29.21 against the 29.2 degree cut); Eimerl's 1987 indices lie 7-9e-4 above both rays (TC-1095). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
The golden snapshot gains only the two BBO models (regenerating the whole file locally also rewrote unrelated Raman records within tolerance, which are left as they were). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
Address review of TC-1095: - read the formulas, like the prism indices they are anchored to, as relative to room air at standard-air wavelengths (20 C assumed) and make them absolute, as for the NBS papers (maintainer's decision); - ref. [4] is Chen et al. 2012, not Nikogosyan; - the 29.2 degree cut is the paper's nominal cut, consistent with the computed angle, not an independent check; - compare with Eimerl like for like, both relative to air; - register entry decided, with the stated uncertainty and the open offset; no OEP (maintainer's decision); - BBO on the front pages; golden records of BBO only refreshed; index rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
Mark the reference angle and the prism anchor as inferences, describe the library's incomplete reading, give the Eimerl offset as 6-9e-4, note BBO's assumed temperature and missing table on the crystals page, pin the 800 nm angle at 29.226 degrees, and say in the changelog that the model is made absolute. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Open
6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
BBO gets ordinary and extraordinary index models: the three-term Sellmeier formulas of Tamošauskas, Beresnevičius, Gadonas & Dubietis, Opt. Mater. Express 8, 1410 (2018), doi:10.1364/OME.8.001410, Eq. (1) on p. 1414, valid over 0.188–5.2 µm. They are registered as
tamosauskas_2018/sellmeier_oandtamosauskas_2018/sellmeier_eand become BBO's recommended models ([BBO]indata/solid/defaults.toml). They use the existingn2_sellmeierform, so no new form is needed.Checked against the source
Verification
uv run poe checkon Python 3.14: all ten steps, with 100 % coverage.uv run poe test-release.uv run poe test-librarywas not run. This change adds no extraction script: the coefficients are a hand-transcribed source record, checked against the PDF's text layer. The paper library was not available here either.Related
Needed by LupoLab/croak#24 (dispersive SHG FROG with a BBO crystal), which will raise croak's optmat requirement once this is released.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL