Skip to content

Add BBO's ordinary and extraordinary Sellmeier formulas (Tamošauskas 2018) - #48

Open
chrisbrahms wants to merge 6 commits into
LupoLab:mainfrom
chrisbrahms:feature/bbo-tamosauskas
Open

chrisbrahms wants to merge 6 commits into
LupoLab:mainfrom
chrisbrahms:feature/bbo-tamosauskas

Conversation

@chrisbrahms

Copy link
Copy Markdown

What changed

BBO gets ordinary and extraordinary index models: the three-term Sellmeier formulas of Tamošauskas, Beresnevičius, Gadonas & Dubietis, Opt. Mater. Express 8, 1410 (2018), doi:10.1364/OME.8.001410, Eq. (1) on p. 1414, valid over 0.188–5.2 µm. They are registered as tamosauskas_2018/sellmeier_o and tamosauskas_2018/sellmeier_e and become BBO's recommended models ([BBO] in data/solid/defaults.toml). They use the existing n2_sellmeier form, so no new form is needed.

  • Medium. The paper states neither medium nor temperature. Like the prism indices they are fitted to, the formulas are read as relative to room air at standard-air wavelengths (20 °C assumed) and made absolute with Edlén's air, as for the NBS prism papers (TC-546). The model therefore lies about 4.5e-4 above the printed formula evaluated directly. This reading was the maintainer's decision; register entry TC-1095.
  • Docs. The crystals page, the overview, the quickstart and the README; a release-note fragment.
  • Golden values. Only BBO's two models were added to the golden snapshot. Regenerating the whole file locally also rewrote unrelated Raman records within tolerance; those changes were not kept.

Checked against the source

  • The coefficients were read from the rendered page and checked digit by digit against the PDF's text layer.
  • Type I SHG of 800 nm phase-matches at 29.23° (29.21° with the absolute reading). This is consistent with the paper's nominal 29.2° cut (p. 1413), but it is not an independent check: the paper calibrated its crystals against computed 800 nm angles.
  • n_o = n_e at 4.624 µm, against 4.62 µm stated on p. 1415.
  • Against Eimerl et al. 1987, Table I (13 lines, 404.66–1014.0 nm), compared like for like: the new formulas lie lower by 8.3e-4 on average for n_o and 7.4e-4 for n_e, and the birefringence agrees within 2.6e-4. This offset is recorded as open in TC-1095.

Verification

  • uv run poe check on Python 3.14: all ten steps, with 100 % coverage.
  • uv run poe test-release.
  • uv run poe test-library was not run. This change adds no extraction script: the coefficients are a hand-transcribed source record, checked against the PDF's text layer. The paper library was not available here either.
  • Two rounds of independent review, with the findings fixed.

Related

Needed by LupoLab/croak#24 (dispersive SHG FROG with a BBO crystal), which will raise croak's optmat requirement once this is released.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL

chrisbrahms and others added 6 commits November 12, 2026 15:18
…2018)

Eq. (1) of Tamošauskas et al., Opt. Mater. Express 8, 1410 (2018), both
rays over 188 nm-5.2 um, as the recommended models of BBO. They
reproduce the type I SHG angle of 800 nm (29.21 against the 29.2 degree
cut); Eimerl's 1987 indices lie 7-9e-4 above both rays (TC-1095).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
The golden snapshot gains only the two BBO models (regenerating the whole
file locally also rewrote unrelated Raman records within tolerance, which
are left as they were).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
Address review of TC-1095:
- read the formulas, like the prism indices they are anchored to, as
  relative to room air at standard-air wavelengths (20 C assumed) and make
  them absolute, as for the NBS papers (maintainer's decision);
- ref. [4] is Chen et al. 2012, not Nikogosyan;
- the 29.2 degree cut is the paper's nominal cut, consistent with the
  computed angle, not an independent check;
- compare with Eimerl like for like, both relative to air;
- register entry decided, with the stated uncertainty and the open offset;
  no OEP (maintainer's decision);
- BBO on the front pages; golden records of BBO only refreshed; index
  rebuilt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
Mark the reference angle and the prism anchor as inferences, describe the
library's incomplete reading, give the Eimerl offset as 6-9e-4, note BBO's
assumed temperature and missing table on the crystals page, pin the
800 nm angle at 29.226 degrees, and say in the changelog that the model
is made absolute.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WM2AxMiUXc12ViRwSf2cyL
@chrisbrahms chrisbrahms added enhancement New feature or request data A source record, an extraction, an erratum or a curated value area: dispersion Gas dispersion models and refractivity area: solids Glasses, crystals and metals labels Nov 13, 2026
@read-the-docs-community

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dispersion Gas dispersion models and refractivity area: solids Glasses, crystals and metals data A source record, an extraction, an erratum or a curated value enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant