Skip to content

fix(release): prepare release candidates explicitly - #61

Merged
choskeli merged 1 commit into
mainfrom
fix/freeze-release-candidate
Oct 28, 2026
Merged

choskeli merged 1 commit into
mainfrom
fix/freeze-release-candidate

Conversation

@choskeli

Copy link
Copy Markdown
Contributor

Main pushes currently rewrite Release Please candidates and invalidate their checks. Prepare/refresh proposals only on explicit Release Please dispatch; pushes still process merged release PRs into their exact tags and drafts.

Based on merged #60, 68cb2607613b9498150db4380cafa4f31d57a227. The rebase preserved the tested tree exactly and does not restore #55's queue code.

  • Use the existing pinned action's native skip-github-pull-request input. No custom release state machine, publisher change, parser change, credentials change, or live settings change.
  • Keep the trusted metadata-only title workflow. PR49's bot rewrites suppress pull_request_target; CI approval alone does not trigger its title result. After explicit preparation, a maintainer reopens the PR and verifies both current-head required checks.
  • Document the short release-first merge window. Strict up-to-date checks still require current main; this freezes automatic proposal edits, not a historical whole-tree snapshot. After merge, exact-SHA publication and owner approval can finish while main advances.
  • Compare actual pinned upstream workflows: Release Please separates modes but still updates each push; Node.js isolates releases on release branches. This retains the existing main-based path.

Validation:

  • 6 new deterministic regressions pass, including actual exact-tag handoff, owner-approval guard and fail-closed aggregate scripts with inert fixtures.
  • 17 focused release tests pass; repository formatting, lint, both TypeScript checks and 162 mutation-policy tests pass. Build, actionlint 1.7.12 and whitespace checks pass.
  • Full local npm run check is not green: sandbox loopback was blocked; a permitted native Windows coverage rerun passed 2,125 tests and failed 6 socket-close cases. Those same 6 failures reproduce on unchanged revert: remove native merge queue integration #60 base. The existing publisher fixture suite uses POSIX fake-gh lookup and does not execute correctly on native Windows. Hosted Linux checks remain required.
  • Independent review found no blocking defect. Tests verify our workflow contracts and execute actual inline guards; upstream Release Please 17.6.0 behavior was verified in pinned source, not claimed as a live release test.

Head: 2b7a1733e5f48c40302c9273d6434684db71d1b4. Draft pending hosted checks. No release was dispatched or published.

@choskeli
choskeli force-pushed the fix/freeze-release-candidate branch from 2b7a173 to 54ca836 Compare October 28, 2026 04:21
@choskeli
choskeli marked this pull request as ready for review October 28, 2026 04:30
@choskeli
choskeli merged commit 273888b into main Oct 28, 2026
39 checks passed
@choskeli
choskeli deleted the fix/freeze-release-candidate branch October 28, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants