Open
Conversation
Most CI scripts were using TEST_COMMIT but jenkinsfile.extended and jenkinsfile.manual define it as TEST_BRANCH. Values were not being honored in jenkins. cloneTests.bat: cloneTests.sh: runJob.bat: runJob.sh: runJobAndroid.sh: - Change TEST_COMMIT to TEST_BRANCH
johnzupin
added
the
approved-to-run-ci
Contributor
Author
|
http://jenkins:8080/job/gfxr-pipelines/job/gfxr-manual/141/parameters/ is a manual run has the change to gfxreconstruct and it checkouts the correct branch to VulkanTests. http://jenkins:8080/job/gfxr-pipelines/job/gfxr-manual/144/parameters/ is a manual run without the change to gfxreconstruct and it fails to checkout the branch to VulkanTests, it just checkouts test.ref. |
Contributor
Author
|
Failure to internal CI, will look into it, but it is still displaying the correct behavior checking out what is in the test.ref file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most CI scripts were using TEST_COMMIT but jenkinsfile.extended and jenkinsfile.manual define it as TEST_BRANCH. Values defined for a branch to test on VulkanTests were not being honored in jenkins.
cloneTests.bat:
cloneTests.sh:
runJob.bat:
runJob.sh:
runJobAndroid.sh: