Open
Conversation
Currently `--wsi auto` (default flag) is adding all surface extensions from the replay and trying to initialize their compositors. This is done to deal with an edge case of where multiple WSIs are available in the caputre. However, when compositors are not available on the replay device, the surface extensions are not removed leading to the application breaking during the `vkCreateInstance` call with `VK_ERROR_EXTENSION_NOT_PRESENT`. This makes `--remove-unsupported` a required option to replay the trace. Instead of adding all the surface extensions from the replay and then removig some if they are not available. This change proposes to add them if they are available, by going through all the capture time surface extensions and checking if they are available and then adding them. Change-Id: I5c0ae6ab6240e75ee2520174a1dcdd0e17791444
fabian-lunarg
added
the
approved-to-run-ci
MarkY-LunarG
reviewed
Apr 1, 2026
| all_capture_surface_extensions += ext; | ||
| all_capture_surface_extensions += ", "; | ||
| } | ||
| GFXRECON_LOG_WARNING("--wsi auto: could not find surface: %sinstead using: %s", |
Contributor
There was a problem hiding this comment.
You removed the comma and space after the first %s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
--wsi auto(default flag) is adding all surface extensions from the replay and trying to initialize their compositors. This is done to deal with an edge case of where multiple WSIs are available in the caputre. However, when compositors are not available on the replay device, the surface extensions are not removed leading to the application breaking during thevkCreateInstancecall withVK_ERROR_EXTENSION_NOT_PRESENT. This makes--remove-unsupporteda required option to replay the trace.The change that creates this behaviour is introduced in PR #2736, while testing the fix I could not reproduce the issue with
vulkaninfothat originally prompted this change.Instead of adding all the surface extensions from the replay and then removing some if they are not available. This change proposes to add them if they are available, by going through all the capture time surface extensions and checking if they are available and then adding them.