Open
Conversation
zongdu-arm
force-pushed
the
fix_issues_for_dx12
branch
3 times, most recently
from
db7abd8 to
4628883
Compare
Contributor
Author
|
@fabian-lunarg , @davidd-lunarg, @locke-lunarg |
zongdu-arm
force-pushed
the
fix_issues_for_dx12
branch
from
4628883 to
fa33340
Compare
1. Fixed a crash where the `OpenExistingHeapFromFileMapping` and `OpenExistingHeapFromAddress1` methods were missing. 2. Fixed an issue where the `SetPrivateDataInterface` method was missing during trimming. 3. Fixed a reference count error in the private data interface, causing a replay crash when releasing resource objects. 4. Fixed an issue with ID3D10Blob trimmed capture: the ID3D10Blob creation command released it in tracking state, not written to the trimmed file. 5. Fixed the heap flags with D3D12_HEAP_FLAG_ALLOW_WRITE_WATCH using UseWriteWatch. 6. Updated the `clang-format` code.
zongdu-arm
force-pushed
the
fix_issues_for_dx12
branch
from
fa33340 to
34a18be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenExistingHeapFromFileMappingandOpenExistingHeapFromAddress1methods were missing.SetPrivateDataInterfacemethod was missing during trimming.clang-formatcode.Track in #2843