Abort on invalid measurement range#2800
Open
marius-pelegrin-arm wants to merge 1 commit intoLunarG:devfrom
Open
Abort on invalid measurement range#2800marius-pelegrin-arm wants to merge 1 commit intoLunarG:devfrom
marius-pelegrin-arm wants to merge 1 commit intoLunarG:devfrom
Conversation
MarkY-LunarG
approved these changes
Apr 2, 2026
Currently, invalid measurement ranges only display a warning message (widely ignored by most users) and continue with the option disabled. This can lead to further issues if the user relies on measurements being present (because he specified the option) in an automation for instance. This commit proposes to fix the situation by aborting on invalid measurement ranges. This commit also add handling for the case where the measurement range specified by the user starts at frame `0` which doesn't exist. Change-Id: I189d5c50b31933bcc0e51fd65cdc3b05542b48a1
MarkY-LunarG
force-pushed
the
measurement-range-sanitization
branch
from
928d4a2 to
9344788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, invalid measurement ranges only display a warning message (widely ignored by most users) and continue with the option disabled.
This can lead to further issues if the user relies on measurements being present (because he specified the option) in an automation for instance.
This commit proposes to fix the situation by aborting on invalid measurement ranges.
This commit also add handling for the case where the measurement range specified by the user starts at frame
0which doesn't exist.