WIP: Async File read process and dispatch...#2783
WIP: Async File read process and dispatch...#2783jzulauf-lunarg wants to merge 3 commits intoLunarG:devfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eca1e11506
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| GFXRECON_ASSERT(process_frame_number_ == kFirstFrame); | ||
| // async_processing_ | ||
| async_thread_ = std::thread([this]() { this->ProcessBlocksAsync(); }); |
There was a problem hiding this comment.
Starting async mode creates a joinable std::thread (StartAsyncProcessing) but there is no corresponding join()/detach() path before FileProcessor destruction, so running replay with --async-processing will hit std::thread's destructor while still joinable and call std::terminate. This causes a hard crash at teardown even if the worker function already returned, so the async thread lifecycle needs an explicit shutdown/join path.
Useful? React with 👍 / 👎.
jzulauf-lunarg
force-pushed
the
zulauf-async-file-processing
branch
from
eca1e11 to
5420964
Compare
1 participant
WIP:
Async framework applied to synchronous preload. Async next.