Draft
Conversation
| set(HEADLESS TRUE) | ||
| endif () | ||
|
|
||
| if (CMAKE_SIZEOF_VOID_P EQUAL 4) |
Contributor
There was a problem hiding this comment.
Should we modify the message to say something like "If you want 32-bit build support, sync to version XYZ" and also make a tag of that name before we commit this?
Contributor
Author
There was a problem hiding this comment.
To me that doesn't seem like a good idea, since that will stop receiving updated. I wouldn't want to see issues submitted against that old tag, when we don't support it anymore.
Contributor
MarkY-LunarG
left a comment
MarkY-LunarG
left a comment
There was a problem hiding this comment.
Couple of questions.
ziga-lunarg
force-pushed
the
remove-32-bit-support
branch
from
458b77d to
535e952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.