Skip to content

feat: unify native extension UI and optional budgets - #45

Merged
LukasParke merged 7 commits into
mainfrom
agent/extension-defaults-tui
Sep 30, 2026
Merged

LukasParke merged 7 commits into
mainfrom
agent/extension-defaults-tui

Conversation

@LukasParke

@LukasParke LukasParke commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Agent:

What and why

Unify extension presentation around Pi's native theme and width-aware components, using subagents as the reference. Remove built-in spend/turn defaults and hard ceilings without removing explicit budgets or lifecycle safeguards.

  • Label-first subagent/workflow previews, bounded widgets, scalable inspectors and on-demand detail.
  • Native compact/expanded/error/partial rendering across integrations, browsers, search/log and Herdr tools; preserve model-facing text, typed results and images.
  • Clear memory-health lifecycle, compact opt-in dashboard and cancellation-safe native dialogs.
  • Workflow budget migration and per-package documentation/version preparation; no npm publication or global Pi upgrade.

Verification

  • npm run check: 1,469 passed, 9 skipped; typecheck and formatting pass.
  • npm run pack:check: pass, including isolated integration bundle verification.
  • Native loader: 20 entrypoints, 72 tools, zero errors; exposure/schema contracts unchanged.
  • Registered renderer fixtures at narrow/60/80/120 widths; red-green regressions for fixed-height streaming, tiny viewport selection, crawl timeout state, complete expanded diagnostics, mutation URLs and output pointers.
  • Real ChildRunner + deterministic subprocess fixture: omitted workflow budget completes 510 turns; explicit turn/spend budgets enforce their stop reasons.

Lifecycle fixtures cover widgets/inspectors, dialog outcomes, shutdown cleanup, dashboard opt-in/local inspection, and stale Graphiti health results across session changes. A red-green regression also fixed an old memory_status invocation repainting a replacement session. Independent re-review is being completed on this same branch before merge. Tests do not use live models/services/owner credentials. Manual interactive-terminal use is not claimed.

See docs/extension-ui.md for coverage of all 25 packages and migration details. Cancellation, timeouts, concurrency, nesting, trust, permissions, confirmation/auth, monitor gates and Gauntlet iteration controls remain intact.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 834a0bbf-80bb-4370-8304-c98cc2abfa6a


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LukasParke

Copy link
Copy Markdown
Owner Author

Agent: Independent spec/correctness and standards review, followed by focused detail/lifecycle and sanitizer re-review, is complete with no outstanding actionable findings in the reviewed scope. CodeRabbit skipped this OSS review; its status is not being treated as a code review.

Final local verification on 7f0c0c2:

  • Node 22.23.1: 1,475 passed / 3 skipped, typecheck and formatting pass.
  • Node 24.21.0: 1,469 passed / 9 skipped, typecheck and formatting pass.
  • Packaging and native loading pass: 20 entrypoints, 72 tools, zero errors.

The Node 22 OSC sanitizer failure was reproduced and fixed using Pi’s native stripTerminalSequences rather than weakening the assertions. Manual interactive-terminal use is not claimed. Waiting for CI on this exact head before merge.

@LukasParke
LukasParke merged commit 97cada1 into main Sep 30, 2026
2 checks passed
@LukasParke
LukasParke deleted the agent/extension-defaults-tui branch September 30, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant