Repository navigation
Preserve WoW card metadata when Blizzard sends blank fields - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression coverage
Validation
8da63578e41162e66428f54b8f3aa540a21876a3.-D warnings, whole-workspace tests, UI regression tests and the simulation smoke run.cargo fmt --all -- --check: passed.-D warnings: passed.pkg-config/GTK/WebKit are absent and the package mirror is blocked. The full workspace checks subsequently passed in CI.Complete refresh write set
bnet_level: positivei32only; missing, zero, negative or overflow preserves saved value.bnet_last_login: valid integer-millisecond timestamp only; missing/invalid preserves,greatestprevents regression.class: trimmed nonblank name, normalized to uppercase ASCII letters; empty result becomes NULL,coalescepreserves saved value.race: trimmed nonblank name (plain oren_US), capped at 40 characters; missing/blank preserves.gender: trimmed nonblank type, lowercased; missing/blank preserves.bnet_spec: same guarded name handling as race; missing/blank preserves.faction: exact Blizzard stableHORDE/ALLIANCEenum only; missing/blank/unknown preserves.bnet_id: existing non-NULL ID always wins; only a positive integer can fill NULL.bnet_checked_at: set tonow()as the refresh bookkeeping timestamp.Guild/avatar/media are not written by this function. No migration, merge, deployment or live server access. No user data touched.