Repository navigation
Raise contrast in the WoW character popup header - #39
Merged
Merged
Conversation
The level, race, spec and class line uses a lighter AA grey, with the class name in its class colour. The realm or ruleset is bright and medium-bold, and the version and region stay a softer but still AA-legible grey. The faction crest sits next to the character name with a light outline, slightly larger than before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The WoW character popup header was hard to read on both Retail and Forever: the level/race/spec/class line and the server line used the dim
.subgrey (#626b76, below WCAG AA on the header gradient), and a small faction crest sat after the server line with no outline.#c8ced6(4.5:1 or better on both ends of the#1a2533→#111419header gradient), with the class name in the existing class colour, as on the profile cards.#eef2f6) and medium-bold, followed by· Forever · US/· Retail · USin a softer#b9bec5that still meets AA.#a7d08c, already AA) at a matching 13px size.CSS and JS only. No database, hour, identity or API changes. Base:
2978f1bfrom latest wow-played.Validation
cargo fmt --all -- --check: passed.cargo clippy -p fraglink-server -p fraglink-core -p fraglink-sync --all-targets -- -D warnings: passed.apps/site-web/tests/wow-*.cjs): 25 passed, including a popup-header layout test and a WCAG contrast check of the new header colours against both gradient ends.cargo testfor those same crates against box Postgres: all passed (core 110 passed / 1 ignored; server lib and integration suites; sync 8 passed).Fixture-only before/after preview (not live account data):
/workspace/pr39-preview/popup-header.png.No merge or deployment performed.