Repository navigation
Use character avatars for Forever WoW characters - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Forever character portraits now come from Battle.net character media on profile cards, the View all gallery, manager rows and the popup. Missing, failed or broken avatars fall back to the class icon. Retail rendering is unchanged.
The media-only endpoint uses the realmless US
/profile/wow/character/<first>-<surname>/character-media?namespace=profile-forever-usURL. It reuses warm popup media or keeps a bounded in-memory cache (12 hours for found portraits, 10 minutes for misses). Client requests are deduplicated and limited to six at a time. The existingBNET_FOREVER_LOOKUPgate remains unchanged.Public avatar requests pass the existing profile/character visibility checks before reading media. Signed-in owners can see their own hidden-character avatars in the manager. Responses are private/no-store. Only the Blizzard render host is accepted, and a known character id must match the media response.
Data safety
No migrations, persistent cache writes, character updates, hour updates, merges, rewrites or deletes. The new server route only reads the database and GETs public media. No OAuth or ownership changes. Base:
c7e524784a900d4d3046633a3f6b870db96c6897from latest wow-played.Validation
Fixture-only static mock preview:
/workspace/pr36-preview/forever-avatars.png(HTML, PDF and synthetic portrait fixtures alongside it). No live account data was used. It is a rendered mock, not signed-in browser QA.No merge, deployment or live flag changes performed.
CI status
Green on
4b2552c993cae3c32a2f456c6c417be180be68ba: Linux whole-workspace fmt, clippy, tests and simulation passed; Windows tests, clippy and unsigned-installer packaging passed. The earlier Linux dependency-install delay cleared without workflow changes or reruns.Run: https://github.com/Lucrona/fraglink/actions/runs/42819448530