Repository navigation
Hide WoW on profiles, and tidy the manager and upload page - #33
Merged
Merged
Conversation
None is a profile display choice. The public roster toggle only appears when both versions have visible characters. The manager lives in Account settings as well as on its own page, with Add characters and Your characters split apart. Co-authored-by: Lucrona <Lucrona@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge or deploy.
Adds None to Show on profile (
wow_prefs.profile_show, migration0059_wow_profile_none.sql). The public profile drops the WoW section. View all shows a plain empty page, not a 404. The Retail/Forever toggle only appears when both versions have visible characters. Repeated names on View all are different realms, so the realm is shown on the card.The manager is also a World of Warcraft tab in Account settings (hidden when the account has no WoW time).
/connect/battlenetstill renders the same manager. Upload /played names the version and writes out both file paths.Settings, desktop
Settings, None
Upload Forever
View all
Head
c836a0f284d2fe0f8d59995babf033bd40886252.To show artifacts inline, enable in settings.